Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pino 7 #8

Merged
merged 15 commits into from
Sep 23, 2021
Merged

Pino 7 #8

merged 15 commits into from
Sep 23, 2021

Conversation

Eomm
Copy link
Contributor

@Eomm Eomm commented Sep 22, 2021 •
edited
Loading

Opening as a draft because I think the implementation is not optimal

In the index.js file I did not figure out jet why the pump() call does not consume the printer stream as .pipe() does.

The code is working but, as said, it lacks implementation

TODO

  • docs

@Eomm Eomm marked this pull request as ready for review September 22, 2021 17:37
mcollina
mcollina approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 6da560b into pinojs:master Sep 23, 2021
@Eomm Eomm deleted the pino-7 branch September 23, 2021 10:28
@mcollina mcollina mentioned this pull request Sep 27, 2021
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eomm @mcollina