Enable version catalogs #1428
Enable version catalogs #1428
Conversation
# Conflicts: # build.gradle # ktlint-core/build.gradle # ktlint/build.gradle
| } | ||
|
|
||
| test { | ||
| useJUnitPlatform() | ||
| } | ||
|
|
||
| task ktlint(type: JavaExec, dependsOn: classes) { | ||
| main = 'com.pinterest.ktlint.Main' | ||
| task ktlint(type: JavaExec, dependsOn: classes, group: LifecycleBasePlugin.VERIFICATION_GROUP) { |
There was a problem hiding this comment.
Solve ktlint task doesn't appear in verification group, link #1316 (comment).
| [versions] | ||
| gradle = "7.4" | ||
| gradleSha256 = "8cc27038d5dbd815759851ba53e70cf62e481b87494cc97cfd97982ada5ba634" | ||
| kotlin = "1.6.0" |
There was a problem hiding this comment.
Is this accessible in build.gradle.kts? That's where we define the Kotlin version (or the kotlin-dev version for snapshots)
There was a problem hiding this comment.
I've done in Goooler@8d719fd, but something wrong with checksums, it might be a bug of Gradle when using VC in buildSrc with checksums enabled, should we delete verification-metadata.xml?
There was a problem hiding this comment.
Filed a bug to gradle/gradle#20234.
There was a problem hiding this comment.
I've done in Goooler@8d719fd, but something wrong with checksums, it might be a bug of Gradle when using VC in buildSrc with checksums enabled, should we delete
verification-metadata.xml?
Your change Use VC in buildSrc addresses the problem of the distinct kotlinDev version. In this commit the version was actually changed and has been merged to master already. Merging this PR would result in reverting the kotlinDev version in the snapshot. If you can mitigate this, I am happy to merge the PR.
There was a problem hiding this comment.
I've tried again in Goooler@08fefbe, but still failed.
The problem is related to dependency verification, it works if I delete verification-metadata.xml.
|
May we can merge this PR first? |
See remark:
|
|
Thnx for your contribution @Goooler |
Description
https://docs.gradle.org/current/userguide/platforms.html
Addressed from #1316.
Checklist
CHANGELOG.mdis updatedIn case of adding a new rule:
README.mdis updated