Convert gradle build scripts to kts #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
commented
Apr 8, 2022
Goooler
commented
Apr 8, 2022
Goooler
changed the title
Goooler
commented
Apr 9, 2022
Goooler
commented
Apr 15, 2022
| .configureEach { | ||
| kotlinOptions { | ||
| apiVersion = "1.4" | ||
| apiVersion = "1.6" |
There was a problem hiding this comment.
w: API version 1.4 is deprecated and its support will be removed in a future version of Kotlin
There was a problem hiding this comment.
I don't completely know the consequences of us increasing this apiVersion. Will some plugins etc become incompatible? @Tapchicoma ?
There was a problem hiding this comment.
As the apiVersion is sync with Kotlin version by default.
# Conflicts: # ktlint-test/build.gradle
|
Ok, lets give this change a go and hope for the best. 🤞 |
|
@Goooler Tnx for your patience on this issue. Your contributions are welcome. Unfortunately, review and merging sometimes take a bit longer as I have little knowledge about these kind of changes. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up #1428, convert Gradle build scripts to KTS to be type-safe.
https://docs.gradle.org/current/userguide/kotlin_dsl.html
Checklist
CHANGELOG.mdis updatedIn case of adding a new rule:
README.mdis updated