Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert root build.gradle to kts #1663

Merged
merged 10 commits into from
Oct 5, 2022
Merged

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Sep 30, 2022

Description

Follow up #1449, and fix the publish issue in #1503, apply ktlint task for kts files.

  • PR description added
  • tests are added
  • KtLint has been applied on source code itself and violations are fixed
  • documentation is updated
  • CHANGELOG.md is updated

In case of adding a new rule:

build.gradle.kts Outdated Show resolved Hide resolved
@Goooler
Copy link
Contributor Author

Goooler commented Sep 30, 2022

@TWiStErRob Could you take a look at this PR?

@Goooler Goooler marked this pull request as draft October 2, 2022 16:03
Comment on lines +60 to +62
tasks.githubRelease {
dependsOn(provider { shadowJarExecutable })
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Goooler Goooler marked this pull request as ready for review October 4, 2022 14:24
@paul-dingemans paul-dingemans merged commit 28ff448 into pinterest:master Oct 5, 2022
@Goooler Goooler deleted the root_kts branch October 5, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants