Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quickstart/_index.md #4893

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Update quickstart/_index.md #4893

merged 4 commits into from
Apr 30, 2024

Conversation

clubanderson
Copy link
Contributor

fixed some grammar issue

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@t-kikuc
Copy link
Member

t-kikuc commented Apr 23, 2024

@clubanderson
Thank you for your great contribution!

Would you please sign off and pass the DCO check?
cf. https://github.com/pipe-cd/pipecd/pull/4893/checks?check_run_id=24111264579

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clubanderson
Thank you so much for your corrections! 🙏

[EDITED] We'll do the below later, so plz just sign off and pass the DCO.

Would you copy your changes to other versions by the following command?
That's because grammatical corrections should be applied to all versions.
(We're sorry for the unclear process...)

find docs/content/en/*/quickstart/_index.md -type f -exec sed -i '' \
-e 's/on your browser/in your browser/g' \
-e 's/logged in successfully/successfully logging in/g' \
-e 's/at `piped` settings tab/at the `piped` settings tab/g' \
-e 's/will keep running/will run continuously/g' \
-e 's/will not lost/will not be lost/g' \
-e 's/Above are all we need/Above is all that is necessary/g' \
-e 's/deployment would be complete automatically to/deployment is complete and will automatically/g' \
 {} \;

It will copy the changes to:

- docs/content/en/docs-dev/quickstart/_index.md
- docs/content/en/docs-v0.39.x/quickstart/_index.md
- docs/content/en/docs-v0.40.x/quickstart/_index.md
- docs/content/en/docs-v0.41.x/quickstart/_index.md
- docs/content/en/docs-v0.42.x/quickstart/_index.md
- docs/content/en/docs-v0.43.x/quickstart/_index.md
- docs/content/en/docs-v0.44.x/quickstart/_index.md
- docs/content/en/docs-v0.45.x/quickstart/_index.md
- docs/content/en/docs-v0.46.x/quickstart/_index.md

After you do it, I'd like to approve🚀

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz pass DCO 🙏

t-kikuc and others added 3 commits April 29, 2024 09:13
… not supported yet (pipe-cd#4900)

* Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect: older versions

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Add 'yet'

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson
Copy link
Contributor Author

I signed the PR and updated all versions. I do not know what else is blocking this PR now. Please advise

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!!!!

@t-kikuc t-kikuc enabled auto-merge (squash) April 30, 2024 00:00
@t-kikuc t-kikuc changed the title Update _index.md Update quickstart/_index.md Apr 30, 2024
@t-kikuc
Copy link
Member

t-kikuc commented Apr 30, 2024

@clubanderson
Thank you for signing and coping your changes!!
This PR will be merged after another reviewer approves.
You do not need to do something else:)

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much :)

@t-kikuc t-kikuc merged commit 03e5a6c into pipe-cd:master Apr 30, 2024
11 checks passed
@github-actions github-actions bot mentioned this pull request May 13, 2024
khanhtc1202 pushed a commit that referenced this pull request May 13, 2024
* [doc] Added note that Canary or Blue/Green for ECS Service Connect is not supported yet (#4900)

* Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect: older versions

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Add 'yet'

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* updates to all versions of index

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* updates to all versions of index

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Co-authored-by: Tetsuya Kikuchi <97105818+t-kikuc@users.noreply.github.com>
khanhtc1202 pushed a commit that referenced this pull request May 13, 2024
* [doc] Added note that Canary or Blue/Green for ECS Service Connect is not supported yet (#4900)

* Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect: older versions

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Add 'yet'

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* updates to all versions of index

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* updates to all versions of index

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Co-authored-by: Tetsuya Kikuchi <97105818+t-kikuc@users.noreply.github.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
khanhtc1202 added a commit that referenced this pull request May 13, 2024
* Update controlplane overview Grafana dashboad (#4898)

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Support PipelineSync on OUT_OF_SYNC (#4892)

* Support PipelineSync on OUT_OF_SYNC

Signed-off-by: golemiso <3282656+golemiso@users.noreply.github.com>

* apply same fix to pipedv1

Signed-off-by: golemiso <3282656+golemiso@users.noreply.github.com>

---------

Signed-off-by: golemiso <3282656+golemiso@users.noreply.github.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Remove decrecated template (#4901)

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* [doc] Added note that Canary or Blue/Green for ECS Service Connect is not supported yet (#4900)

* Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect: older versions

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Add 'yet'

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Add new adopter (#4897)

Signed-off-by: yutsuki miyashita <yutsukimiya@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Update _index.md (#4893)

* [doc] Added note that Canary or Blue/Green for ECS Service Connect is not supported yet (#4900)

* Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect: older versions

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Add 'yet'

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* updates to all versions of index

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* updates to all versions of index

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Co-authored-by: Tetsuya Kikuchi <97105818+t-kikuc@users.noreply.github.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* [blog] Fix links (#4904)

* Fix links

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Fix links: control-plane-on-ecs.md

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Fix links: remove domain

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

---------

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: golemiso <3282656+golemiso@users.noreply.github.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: yutsuki miyashita <yutsukimiya@gmail.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Co-authored-by: golemiso <3282656+golemiso@users.noreply.github.com>
Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com>
Co-authored-by: Tetsuya Kikuchi <97105818+t-kikuc@users.noreply.github.com>
Co-authored-by: yutsuki miyashita <yutsukimiya@gmail.com>
Co-authored-by: Andy Anderson <andy@clubanderson.com>
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants