-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update quickstart/_index.md #4893
Conversation
@clubanderson Would you please sign off and pass the DCO check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clubanderson
Thank you so much for your corrections! 🙏
[EDITED] We'll do the below later, so plz just sign off and pass the DCO.
Would you copy your changes to other versions by the following command?
That's because grammatical corrections should be applied to all versions.
(We're sorry for the unclear process...)
find docs/content/en/*/quickstart/_index.md -type f -exec sed -i '' \
-e 's/on your browser/in your browser/g' \
-e 's/logged in successfully/successfully logging in/g' \
-e 's/at `piped` settings tab/at the `piped` settings tab/g' \
-e 's/will keep running/will run continuously/g' \
-e 's/will not lost/will not be lost/g' \
-e 's/Above are all we need/Above is all that is necessary/g' \
-e 's/deployment would be complete automatically to/deployment is complete and will automatically/g' \
{} \;
It will copy the changes to:
- docs/content/en/docs-dev/quickstart/_index.md
- docs/content/en/docs-v0.39.x/quickstart/_index.md
- docs/content/en/docs-v0.40.x/quickstart/_index.md
- docs/content/en/docs-v0.41.x/quickstart/_index.md
- docs/content/en/docs-v0.42.x/quickstart/_index.md
- docs/content/en/docs-v0.43.x/quickstart/_index.md
- docs/content/en/docs-v0.44.x/quickstart/_index.md
- docs/content/en/docs-v0.45.x/quickstart/_index.md
- docs/content/en/docs-v0.46.x/quickstart/_index.md
After you do it, I'd like to approve🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz pass DCO 🙏
… not supported yet (pipe-cd#4900) * Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect: older versions Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add 'yet' Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
I signed the PR and updated all versions. I do not know what else is blocking this PR now. Please advise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!!!!
@clubanderson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much :)
* [doc] Added note that Canary or Blue/Green for ECS Service Connect is not supported yet (#4900) * Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect: older versions Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add 'yet' Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: Andrew Anderson <andy@clubanderson.com> * updates to all versions of index Signed-off-by: Andrew Anderson <andy@clubanderson.com> * updates to all versions of index Signed-off-by: Andrew Anderson <andy@clubanderson.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: Andrew Anderson <andy@clubanderson.com> Co-authored-by: Tetsuya Kikuchi <97105818+t-kikuc@users.noreply.github.com>
* [doc] Added note that Canary or Blue/Green for ECS Service Connect is not supported yet (#4900) * Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect: older versions Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add 'yet' Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: Andrew Anderson <andy@clubanderson.com> * updates to all versions of index Signed-off-by: Andrew Anderson <andy@clubanderson.com> * updates to all versions of index Signed-off-by: Andrew Anderson <andy@clubanderson.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: Andrew Anderson <andy@clubanderson.com> Co-authored-by: Tetsuya Kikuchi <97105818+t-kikuc@users.noreply.github.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
* Update controlplane overview Grafana dashboad (#4898) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Support PipelineSync on OUT_OF_SYNC (#4892) * Support PipelineSync on OUT_OF_SYNC Signed-off-by: golemiso <3282656+golemiso@users.noreply.github.com> * apply same fix to pipedv1 Signed-off-by: golemiso <3282656+golemiso@users.noreply.github.com> --------- Signed-off-by: golemiso <3282656+golemiso@users.noreply.github.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Remove decrecated template (#4901) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * [doc] Added note that Canary or Blue/Green for ECS Service Connect is not supported yet (#4900) * Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect: older versions Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add 'yet' Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Add new adopter (#4897) Signed-off-by: yutsuki miyashita <yutsukimiya@gmail.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Update _index.md (#4893) * [doc] Added note that Canary or Blue/Green for ECS Service Connect is not supported yet (#4900) * Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect: older versions Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add 'yet' Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: Andrew Anderson <andy@clubanderson.com> * updates to all versions of index Signed-off-by: Andrew Anderson <andy@clubanderson.com> * updates to all versions of index Signed-off-by: Andrew Anderson <andy@clubanderson.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: Andrew Anderson <andy@clubanderson.com> Co-authored-by: Tetsuya Kikuchi <97105818+t-kikuc@users.noreply.github.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * [blog] Fix links (#4904) * Fix links Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Fix links: control-plane-on-ecs.md Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Fix links: remove domain Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> --------- Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: golemiso <3282656+golemiso@users.noreply.github.com> Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: yutsuki miyashita <yutsukimiya@gmail.com> Signed-off-by: Andrew Anderson <andy@clubanderson.com> Co-authored-by: golemiso <3282656+golemiso@users.noreply.github.com> Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com> Co-authored-by: Tetsuya Kikuchi <97105818+t-kikuc@users.noreply.github.com> Co-authored-by: yutsuki miyashita <yutsukimiya@gmail.com> Co-authored-by: Andy Anderson <andy@clubanderson.com>
fixed some grammar issue
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: