Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blog] Fix links #4904

Merged
merged 3 commits into from
May 1, 2024
Merged

[blog] Fix links #4904

merged 3 commits into from
May 1, 2024

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Apr 30, 2024

What this PR does / why we need it:

I fixed two kinds of invalid URLs in the blogs.

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?: no

  • How are users affected by this change: N/A
  • Is this breaking change: N/A
  • How to migrate (if breaking change): N/A

t-kikuc added 3 commits May 1, 2024 08:14
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.32%. Comparing base (b17c25b) to head (b564c82).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4904      +/-   ##
==========================================
+ Coverage   29.30%   29.32%   +0.01%     
==========================================
  Files         321      321              
  Lines       40835    40835              
==========================================
+ Hits        11968    11974       +6     
+ Misses      27910    27904       -6     
  Partials      957      957              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 commented

Comment on lines -23 to +22

> Note: See [Architecture Overview](/docs/user-guide/managing-controlplane/architecture-overview/) doc for details.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems not to work on make run/site👀

404_Page_not_found___PipeCD

How about using /docs-dev instead of /docs ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might be because make run/site does not show docs (why??)

image

Please visit https://pipecd.dev/blog/2024/03/14/control-plane-on-local-by-docker-compose/ and modify the href. That worked.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t-kikuc Got it. You're right. make run/site couldn't redirect the link.

It seems that the site is hosted by our file server, which works in a container. /docs is redirected to the latest version /docs-<latest-version>.

pipecd/docs/main.go

Lines 28 to 49 in b564c82

const dir = "/public"
// Don't update here manually. /hack/gen-release-docs.sh does.
const latestPath = "/docs-v0.47.x/"
func main() {
var (
doneCh = make(chan error)
mux = http.NewServeMux()
server = &http.Server{
Addr: ":8080",
Handler: mux,
}
fs = http.FileServer(http.Dir(dir))
)
mux.Handle("/", fs)
// Redirect /docs/ to /docs-{latest-version}/
mux.HandleFunc("/docs/", func(w http.ResponseWriter, r *http.Request) {
latestPattern := strings.Replace(r.URL.Path, "/docs/", latestPath, 1)
http.Redirect(w, r, latestPattern, http.StatusTemporaryRedirect)
})

But make run/site uses hugo server command, which creates the server internally to check the behavior and doesn't use our server. 😇

So I tried to execute hugo to build the files and go run main.go in the docs dir, then it worked well.
(I added the small fix to check the build result, change from "/public" to "./public" at this line)

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@t-kikuc t-kikuc merged commit 972d114 into master May 1, 2024
14 checks passed
@t-kikuc t-kikuc deleted the blog-fix-links branch May 1, 2024 10:06
@github-actions github-actions bot mentioned this pull request May 13, 2024
khanhtc1202 pushed a commit that referenced this pull request May 13, 2024
* Fix links

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Fix links: control-plane-on-ecs.md

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Fix links: remove domain

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
khanhtc1202 pushed a commit that referenced this pull request May 13, 2024
* Fix links

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Fix links: control-plane-on-ecs.md

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Fix links: remove domain

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
khanhtc1202 added a commit that referenced this pull request May 13, 2024
* Update controlplane overview Grafana dashboad (#4898)

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Support PipelineSync on OUT_OF_SYNC (#4892)

* Support PipelineSync on OUT_OF_SYNC

Signed-off-by: golemiso <3282656+golemiso@users.noreply.github.com>

* apply same fix to pipedv1

Signed-off-by: golemiso <3282656+golemiso@users.noreply.github.com>

---------

Signed-off-by: golemiso <3282656+golemiso@users.noreply.github.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Remove decrecated template (#4901)

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* [doc] Added note that Canary or Blue/Green for ECS Service Connect is not supported yet (#4900)

* Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect: older versions

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Add 'yet'

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Add new adopter (#4897)

Signed-off-by: yutsuki miyashita <yutsukimiya@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Update _index.md (#4893)

* [doc] Added note that Canary or Blue/Green for ECS Service Connect is not supported yet (#4900)

* Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Add NOTE of not supporting Canary,Blue/Green with ECS Service Connect: older versions

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Add 'yet'

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* updates to all versions of index

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* updates to all versions of index

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Co-authored-by: Tetsuya Kikuchi <97105818+t-kikuc@users.noreply.github.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* [blog] Fix links (#4904)

* Fix links

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Fix links: control-plane-on-ecs.md

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Fix links: remove domain

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

---------

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: golemiso <3282656+golemiso@users.noreply.github.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: yutsuki miyashita <yutsukimiya@gmail.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Co-authored-by: golemiso <3282656+golemiso@users.noreply.github.com>
Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com>
Co-authored-by: Tetsuya Kikuchi <97105818+t-kikuc@users.noreply.github.com>
Co-authored-by: yutsuki miyashita <yutsukimiya@gmail.com>
Co-authored-by: Andy Anderson <andy@clubanderson.com>
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants