Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Max Threads default to os.availableParallelism() https://nodejs.org/api/os.html#osavailableparallelism #497

Closed
metcoder95 opened this issue Jan 28, 2024 · 3 comments · Fixed by #556
Closed

Make Max Threads default to os.availableParallelism() https://nodejs.org/api/os.html#osavailableparallelism #497

metcoder95 opened this issue Jan 28, 2024 · 3 comments · Fixed by #556
Labels
enhancement New feature or request good-first-issue Good for newcomers stale

Comments

@metcoder95
Copy link
Member 

          I think we could default it to `os.availableParallelism()` https://nodejs.org/api/os.html#osavailableparallelism

Originally posted by @RafaelGSS in #487 (comment)
@metcoder95 metcoder95 added enhancement New feature or request good-first-issue Good for newcomers labels Jan 28, 2024
@BenzeneAlcohol
Copy link

BenzeneAlcohol commented Feb 5, 2024 •
edited
Loading

Hi, can I take this issue up?

@metcoder95
Copy link
Member Author

Please! 👍

BenzeneAlcohol added a commit to BenzeneAlcohol/piscina that referenced this issue Feb 6, 2024
@BenzeneAlcohol
src: scheduler
3dbf438 
Added default value to maximumUsage

Fixes: piscinajs#497
@BenzeneAlcohol BenzeneAlcohol mentioned this issue Feb 6, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

This issue has been marked as stale because it has been opened 30 days without activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale label May 5, 2024
@metcoder95 metcoder95 linked a pull request May 5, 2024 that will close this issue
feat: use os.availableConcurrency #556
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good-first-issue Good for newcomers stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use os.availableConcurrency piscinajs/piscina
2 participants
@metcoder95 @BenzeneAlcohol