Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use os.availableConcurrency #556

Merged
merged 3 commits into from
May 5, 2024
Merged

feat: use os.availableConcurrency #556

merged 3 commits into from
May 5, 2024

Conversation

metcoder95
Copy link
Member

  • feat: use available parallelism instead of cpu count
  • fix: smaller adjustments

@metcoder95 metcoder95 merged commit d1fbba2 into current May 5, 2024
10 checks passed
@metcoder95 metcoder95 deleted the feat/concurrency branch May 5, 2024 19:46
@cjinhuo
Copy link

cjinhuo commented May 22, 2024

hello excuse me, os.availableConcurrency added in: v19.4.0, v18.14.0. But I saw README indicate it for Node.js 16.x and higher. And I had installed ^4.4.0 in node16.x enviroment. Today I re-deployed and found it was broken in here.

@cjinhuo
Copy link

cjinhuo commented May 22, 2024

Can I pull a request to fix this issue

@cjinhuo
Copy link

cjinhuo commented May 22, 2024

Can I pull a request to fix this issue

please check this PR

@metcoder95
Copy link
Member Author

Workaround has been done, please verify 4.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Max Threads default to os.availableParallelism() https://nodejs.org/api/os.html#osavailableparallelism
3 participants