Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MS Edge: clicking a link in a sidebar mod crashes MS Edge #8206

Closed
twschiller opened this issue Apr 9, 2024 · 8 comments
Closed

MS Edge: clicking a link in a sidebar mod crashes MS Edge #8206

twschiller opened this issue Apr 9, 2024 · 8 comments
Assignees
@grahamlangford
Labels
bug Something isn't working customer Required for a customer projct edge MS Edge Chromium support triage wontfix This will not be worked on

Comments

@twschiller
Copy link
Contributor

twschiller commented Apr 9, 2024 •
edited
Loading

Steps to Reproduce

  • Click the "Open Google Sheet" link in the Announcements/Notices Mod Sidebar

Actual Behavior

  • MS Edge crashes
  • PixieBrix no longer installed (might only impact load unpacked?)

Discussion

Playwright Test Scenarios (can be put in a single test mod)

  • Click the gear to open the Extension Console
  • Use a test mod with the following: @pixies/test/sidebar-links
    • Open in tab brick
    • Link in markdown rendered in text element
    • Link in embedded HTML brick
    • Link in embedded form: form description and field description support markdown. Likely only need to test 1
@twschiller twschiller added mv3 bug Something isn't working edge MS Edge Chromium support customer Required for a customer projct and removed mv3 labels Apr 9, 2024
@twschiller twschiller changed the title MS Edge: clicking a link a sidebar mod crashes MS Edge MS Edge: clicking a link in a sidebar mod crashes MS Edge Apr 9, 2024
@fregante fregante mentioned this issue Apr 10, 2024
Merged
3 tasks
twschiller pushed a commit that referenced this issue Apr 10, 2024
@fregante
#8206: Avoid Edge crash when opening user links (#8211)
3e1a159
@twschiller
Copy link
Contributor Author

twschiller commented Apr 10, 2024 •
edited
Loading

PR merged. Remaining work is to add playwright test for the scenarios. Assigning to myself for tests

@twschiller twschiller self-assigned this Apr 10, 2024
twschiller added a commit that referenced this issue Apr 10, 2024
@twschiller
#8206: playwright tests for links
e52a302
@twschiller twschiller mentioned this issue Apr 10, 2024
Merged
4 tasks
@twschiller
Copy link
Contributor Author

twschiller commented Apr 10, 2024 •
edited
Loading

@fregante how was the PR tested? On https://github.com/pixiebrix/pixiebrix-extension/actions/runs/8638318978 the gear icon isn't doing anything for me. It doesn't change style on hover and isn't responding to clicks

I documented additional problems in the PR: #8216 (comment)

  • The sidebar closes when you click a link (is that intended?)
  • MS Edge crashes if you click a link in an iframe

@twschiller twschiller assigned fregante and unassigned twschiller Apr 10, 2024
@fregante
Copy link
Contributor

Commented in your PR

@twschiller twschiller mentioned this issue Apr 11, 2024
Closed
This was referenced Apr 11, 2024
Closed
Closed
twschiller added a commit that referenced this issue Apr 11, 2024
@twschiller
#8206: add more comments on playwright issues
95b9b86
@twschiller
Copy link
Contributor Author

I've submitted a minimal reproduction to the MS Edge team: microsoft/MicrosoftEdge-Extensions#145

fungairino added a commit that referenced this issue May 15, 2024
@twschiller @mnholtz
@grahamlangford @fungairino
#8206: playwright tests for MS Edge sidebar links (#8216)
8a67ea8 
* #8206: playwright tests for links

* Open the extension console

* Fix jest snapshots

* Add commentary on MS Edge behavior and try to fix

* #8206: add more comments on playwright issues

* Work around msedge bugs

* fix snapshots

* wip

* fix snapshots

* always reopen sidebar

* wip

* fix e2e flakiness with deleting mods cleanup

* lint fix

* skip iframe link test in linux

* fix os check

* fix os check

* fix osname check

---------

Co-authored-by: Misha Holtz <36575242+mnholtz@users.noreply.github.com>
Co-authored-by: Graham Langford <30706330+grahamlangford@users.noreply.github.com>
Co-authored-by: Eduardo <eduardo@pixiebrix.com>
This was referenced May 15, 2024
Merged
Closed
Closed
Merged
@twschiller
Copy link
Contributor Author

@grahamlangford on Chrome I'm seeing that the browser automatically injects the content script. However, on MS Edge the content script is not injected

Chrome:
image

MS Edge:
image

I think we're going to have to raise with w3c extensions and MS Edge issue tracker that there's a discrepancy in which frames the content script is automatically injected into

In your research, are we even able to inject the content script into a frame within the sidebar in MS Edge?

@grahamlangford
Copy link
Collaborator

In your research, are we even able to inject the content script into a frame within the sidebar in MS Edge?

No, nothing I tried (adjusting permissions, setting to DEBUG, etc.) resulted in the content script getting injected

This was referenced Sep 20, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 29, 2024
Closed
Closed
Merged
Merged
Merged
Merged
Merged
This was referenced Oct 7, 2024
Merged
Merged
This was referenced Oct 16, 2024
Merged
Closed
Merged
Merged
This was referenced Oct 24, 2024
Closed
Merged
This was referenced Nov 3, 2024
Merged
Merged
Closed
This was referenced Nov 10, 2024
Merged
Closed
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grahamlangford grahamlangford

Labels
bug Something isn't working customer Required for a customer projct edge MS Edge Chromium support triage wontfix This will not be worked on
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fregante @twschiller @grahamlangford