-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mixpanel Lexicon to version control #9149
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main pixiebrix/pixiebrix-extension#9149 +/- ##
==========================================
+ Coverage 74.24% 74.81% +0.57%
==========================================
Files 1332 1365 +33
Lines 40817 42048 +1231
Branches 7634 7851 +217
==========================================
+ Hits 30306 31460 +1154
- Misses 10511 10588 +77 ☔ View full report in Codecov by Sentry. |
Playwright test resultsDetails Open report ↗︎ Flaky testsmsedge-setup › setup/affiliated.setup.ts › authenticate with affiliated user Skipped testschrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor |
I'll need support from @grahamlangford to configure service acct credentials for the workflow. Would like to do a test run before deploying to ensure the workflow is configured properly |
|
||
/** | ||
* Transforms a LexiconMap into a JSON schema that can be used in the request body to upload the Lexicon to Mixpanel. | ||
* See expected shape here https://developer.mixpanel.com/reference/upload-schemas-for-project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick search, but it doesn't seem like there's any vended types for this type of request, right?
src/telemetry/lexicon.ts
Outdated
* Transforms a LexiconMap into a JSON schema that can be used in the request body to upload the Lexicon to Mixpanel. | ||
* See expected shape here https://developer.mixpanel.com/reference/upload-schemas-for-project | ||
*/ | ||
export function transformLexicon(lexiconMap: LexiconMap): JSONSchema { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe a more specific method name? transformLexiconMapToRequestSchema
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
FYI @Pashaminkovsky |
What does this PR do?
Future Work
@ts-expect-error
flag on the LexiconMap and complete the lexicon with event descriptions/tags/display names