Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not automatically close the sidebar while the Page Editor is open #8104

Closed
twschiller opened this issue Mar 30, 2024 · 0 comments · Fixed by #8425
Closed

Do not automatically close the sidebar while the Page Editor is open #8104

twschiller opened this issue Mar 30, 2024 · 0 comments · Fixed by #8425
Assignees
Labels
bug Something isn't working page editor user experience Improve the user experience (UX)

Comments

@twschiller
Copy link
Contributor

twschiller commented Mar 30, 2024

Describe the bug

  • If the mod panel is the only panel open, the sidebar automatically closes when saving a mod because the dynamic element is removed from the page and the saved version is added to the page
  • Auto-closing is jarring with the Chromium Sidepanel and annoying because you have to re-open the sidebar/re-render the panel to continue working

To Reproduce

Steps to reproduce the behavior:

  1. Create a mod package with a sidebar
  2. Run the mod so it's the only sidebar panel
  3. Make a change and save the mod

Actual behavior

The sidebar is automatically closed

Expected behavior

The sidebar is open to the saved version of the mod you are working on

Discussion

  • An alternative approach would be to debounce the hide because the panel will be immediately re-added. However, that would introduce a race condition. Not auto-hiding while the Page Editor is open seems like the easiest approach

Desktop (please complete the following information):

  • Browser: Chrome
  • Extension Version: 1.8.11

Related Code

@twschiller twschiller added bug Something isn't working user experience Improve the user experience (UX) page editor labels Mar 30, 2024
@fungairino fungairino self-assigned this May 7, 2024
fungairino added a commit that referenced this issue May 9, 2024
…Editor (#8425)

* Do not automatically close the sidebar when saving in the Page Editor

* bumped up retry length of deletion dropdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working page editor user experience Improve the user experience (UX)
2 participants