Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9250 Delete action for unsaved Mods #9255

Merged
merged 15 commits into from
Oct 9, 2024
Merged

Conversation

mnholtz
Copy link
Collaborator

@mnholtz mnholtz commented Oct 9, 2024

@twschiller twschiller added the do not merge Merging of this PR is blocked by another one label Oct 9, 2024
@twschiller twschiller added this to the 2.1.5 milestone Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

When the PR is merged, the first loom link found on this PR will be posted to #sprint-demo on Slack. Do not edit this comment manually.

Base automatically changed from feature/9250_refactor to main October 9, 2024 17:23
@twschiller twschiller removed the do not merge Merging of this PR is blocked by another one label Oct 9, 2024
@twschiller
Copy link
Contributor

@mnholtz you'll need rebase/fix the merge conflict

# Conflicts:
#	src/pageEditor/modListingPanel/ModActionMenu.tsx
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.10%. Comparing base (8318d74) to head (7d58495).
Report is 355 commits behind head on main.

Files with missing lines Patch % Lines
src/pageEditor/hooks/useDeactivateMod.tsx 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9255      +/-   ##
==========================================
+ Coverage   74.24%   75.10%   +0.85%     
==========================================
  Files        1332     1370      +38     
  Lines       40817    42305    +1488     
  Branches     7634     7891     +257     
==========================================
+ Hits        30306    31773    +1467     
- Misses      10511    10532      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 9, 2024

Playwright test results

passed  134 passed
flaky  4 flaky
skipped  4 skipped

Details

report  Open report ↗︎
stats  142 tests across 46 suites
duration  13 minutes, 28 seconds
commit  7d58495
info  For more information on how to debug and view this report, see our readme

Flaky tests

chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add new mod with different starter brick components
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/copyMod.spec.ts › run a copied mod with a built-in integration

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@mnholtz mnholtz merged commit 3db423b into main Oct 9, 2024
20 checks passed
@mnholtz mnholtz deleted the feature/9250_delete_unsaved_mods branch October 9, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page editor user experience Improve the user experience (UX)
Development

Successfully merging this pull request may close these issues.

Replace "Deactivate" mod action with "Delete" for UnsavedMods
2 participants