-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#9250 Delete action for unsaved Mods #9255
Conversation
When the PR is merged, the first loom link found on this PR will be posted to |
@mnholtz you'll need rebase/fix the merge conflict |
# Conflicts: # src/pageEditor/modListingPanel/ModActionMenu.tsx
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9255 +/- ##
==========================================
+ Coverage 74.24% 75.10% +0.85%
==========================================
Files 1332 1370 +38
Lines 40817 42305 +1488
Branches 7634 7891 +257
==========================================
+ Hits 30306 31773 +1467
- Misses 10511 10532 +21 ☔ View full report in Codecov by Sentry. |
Playwright test resultsDetails Open report ↗︎ Flaky testschrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod Skipped testschrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor |
What does this PR do?
Demo