Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "Deactivate" mod action with "Delete" for UnsavedMods #9250

Closed
mnholtz opened this issue Oct 7, 2024 · 0 comments · Fixed by #9255
Closed

Replace "Deactivate" mod action with "Delete" for UnsavedMods #9250

mnholtz opened this issue Oct 7, 2024 · 0 comments · Fixed by #9255
Assignees
@mnholtz
Labels
page editor user experience Improve the user experience (UX)

Comments

@mnholtz
Copy link
Collaborator

mnholtz commented Oct 7, 2024

Initial re-slicing for Eliminating Standalone Mods didn't cover the "Deactivate" mod action for unsaved mods.

Acceptance Criteria

Delete action in place of Deactivate action
Given an unsaved mod in the Page Editor
When the user clicks on the ellipsis menu
Then they will see a "Delete" action instead of a "Deactivate" action

Delete confirmation modal for unsaved mods
Given an unsaved mod in the Page Editor
When the user clicks on the "delete" action
Then they will see a delete confirmation modal
@twschiller twschiller added user experience Improve the user experience (UX) page editor labels Oct 7, 2024
@mnholtz mnholtz self-assigned this Oct 9, 2024
This was referenced Oct 9, 2024
Merged
Merged
mnholtz added a commit that referenced this issue Oct 9, 2024
@mnholtz
#9250 Refactor ModActionItem remove unnecessary props (#9254)
986ba71 
* remove onDeactivate prop drill

* remove onSave prop drill

* remove addStarterBrick prop drill

* remove onClearChanges prop drill

* remove onMakeCopy prop drill

* move isDirty into ModActionMenu

* remove isActive prop

* remove ModListItemProps type

* remove TODO comment
mnholtz added a commit that referenced this issue Oct 9, 2024
@mnholtz
#9250 Delete action for unsaved Mods (#9255)
3db423b 
* remove onDeactivate prop drill

* remove onSave prop drill

* remove addStarterBrick prop drill

* remove onClearChanges prop drill

* remove onMakeCopy prop drill

* move isDirty into ModActionMenu

* remove isActive prop

* remove ModListItemProps type

* add delete action and modal for unsaved mods

* add comment to useDeactivateMod

* add faTrash icon for unsaved mods

* remove TODO comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnholtz mnholtz

Labels
page editor user experience Improve the user experience (UX)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#9250 Delete action for unsaved Mods pixiebrix/pixiebrix-extension
2 participants
@twschiller @mnholtz