Add additional optional chaining to prevent import errors when chrome api not available

[mnholtz]

What does this PR do?

• Follow-up of #8273: Fix App crashing when chrome runtime is undefined #8275
• It looks like optional chaining that we added was not enough to prevent import errors.

Discussion

• For some reason, the changes made in the previous PR were passing cypress tests in headless mode (and local builds looked fine) but Misha's cypress tests are failing in UI mode, and staging is down
• We should seriously consider adding smoke tests to dev and staging

Checklist

• Add jest or playwright tests and/or storybook stories
• Designate a primary reviewer @johnnymetz

[github-actions]

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.41%. Comparing base (6d95047) to head (120583e).
Report is 36 commits behind head on main.

Files	Patch %	Lines
src/mv3/api.ts	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8432      +/-   ##
==========================================
- Coverage   73.47%   73.41%   -0.06%     
==========================================
  Files        1334     1352      +18     
  Lines       41259    41520     +261     
  Branches     7686     7773      +87     
==========================================
+ Hits        30316    30483     +167     
- Misses      10943    11037      +94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[BLoe]

I'm pretty sure you can also just keep chaining the null-safe access as before, if you want:

Suggested change

	if (!chrome.runtime?.getManifest) {
	return false;
	}
	// Use optional chaining in case the chrome runtime is not available:
	// https://github.com/pixiebrix/pixiebrix-extension/issues/8273
	return chrome.runtime.getManifest().manifest_version === 3;
	// Use optional chaining in case the chrome runtime is not available:
	// https://github.com/pixiebrix/pixiebrix-extension/issues/8273
	return chrome.runtime?.getManifest?.()?.manifest_version === 3;

[mnholtz]

Thanks ben, I actually didn't remember that you could put the double parentheses after the null operator.

[github-actions]

Playwright test results - MV2

 41 passed
 1 flaky
 8 skipped

Details

 Open report ↗︎
 50 tests across 18 suites
 9 minutes, 48 seconds
 120583e

Flaky tests

edge › tests/extensionConsoleActivation.spec.ts › can activate a mod with a database

Skipped tests

chrome › tests/extensionConsoleActivation.spec.ts › can activate a mod with built-in integration
edge › tests/extensionConsoleActivation.spec.ts › can activate a mod with built-in integration
chrome › tests/runtime/sidebarController.spec.ts › sidebar controller › shows focus dialog in top-level frame
edge › tests/runtime/sidebarController.spec.ts › sidebar controller › shows focus dialog in top-level frame
chrome › tests/runtime/sidebarNavigation.spec.ts › sidebar mod panels are persistent during navigation
chrome › tests/runtime/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation
edge › tests/runtime/sidebarNavigation.spec.ts › sidebar mod panels are persistent during navigation
edge › tests/runtime/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation

[github-actions]

Playwright test results - MV3

 48 passed
 2 flaky

Details

 Open report ↗︎
 50 tests across 18 suites
 14 minutes, 29 seconds
 120583e

Flaky tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
edge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor