#8273: Fix App crashing when chrome runtime is undefined #8275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
chrome.runtime
is undefined #8273Discussion
isExtensionContext()
. But @grahamlangford and I decided to use optional chaining because it's simpler. Plus we will delete thesrc/mv3/api.ts
file when the MV3 transition is complete so no need to create a robust solution here.Demo
https://www.loom.com/share/6884cee3ed74460799897b9c855b318e
Future Work
Checklist