Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom eslint rule for e2e test length #8431

Merged
merged 1 commit into from
May 13, 2024
Merged

custom eslint rule for e2e test length #8431

merged 1 commit into from
May 13, 2024

Conversation

fungairino
Copy link
Collaborator

@fungairino fungairino commented May 9, 2024

This rule will encourage us to break up long tests using refactored page methods or test.step

Primary reviewer @grahamlangford

Copy link

github-actions bot commented May 9, 2024

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.43%. Comparing base (6d95047) to head (235163d).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8431      +/-   ##
==========================================
- Coverage   73.47%   73.43%   -0.05%     
==========================================
  Files        1334     1352      +18     
  Lines       41259    41518     +259     
  Branches     7686     7772      +86     
==========================================
+ Hits        30316    30487     +171     
- Misses      10943    11031      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 9, 2024

Playwright test results - MV2

passed  38 passed
flaky  4 flaky
skipped  8 skipped

Details

report  Open report ↗︎
stats  50 tests across 18 suites
duration  11 minutes, 12 seconds
commit  235163d

Flaky tests

chromeSetup › auth.setup.ts › authenticate
chrome › tests/extensionConsoleActivation.spec.ts › can activate a mod with a database
edge › tests/extensionConsoleActivation.spec.ts › can activate a mod with a database
edge › tests/pageEditor/saveMod.spec.ts › can save a standalone trigger mod

Skipped tests

chrome › tests/extensionConsoleActivation.spec.ts › can activate a mod with built-in integration
edge › tests/extensionConsoleActivation.spec.ts › can activate a mod with built-in integration
chrome › tests/runtime/sidebarController.spec.ts › sidebar controller › shows focus dialog in top-level frame
edge › tests/runtime/sidebarController.spec.ts › sidebar controller › shows focus dialog in top-level frame
chrome › tests/runtime/sidebarNavigation.spec.ts › sidebar mod panels are persistent during navigation
chrome › tests/runtime/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation
edge › tests/runtime/sidebarNavigation.spec.ts › sidebar mod panels are persistent during navigation
edge › tests/runtime/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation

Copy link

github-actions bot commented May 9, 2024

Playwright test results - MV3

passed  48 passed
flaky  2 flaky

Details

report  Open report ↗︎
stats  50 tests across 18 suites
duration  14 minutes, 8 seconds
commit  235163d

Flaky tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
edge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor

@twschiller twschiller added this to the 2.0.0 milestone May 10, 2024
@fungairino fungairino merged commit b96fc22 into main May 13, 2024
22 checks passed
@fungairino fungairino deleted the test-length-eslint branch May 13, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants