#9257: fix heartbeat telemetry regression

[twschiller]

What does this PR do?

• Closes Invalid mod version number passed in heartbeat #9257

Checklist

• Cut/submit a beta to CWS beta channel

Future Work

• Fix type safety of ModDefinition.metadata.version: Mark version as required on ModDefinition.metadata #9259

For more information on our expectations for the PR process, see the
code review principles doc

[github-actions]

Playwright test results

 131 passed
 7 flaky
 4 skipped

Details

 Open report ↗︎
 142 tests across 46 suites
 15 minutes, 42 seconds
 c7c6627
 For more information on how to debug and view this report, see our readme

Flaky tests

chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/copyMod.spec.ts › run a copied mod with a built-in integration
msedge › tests/pageEditor/liveEditing.spec.ts › live editing behavior
msedge › tests/pageEditor/modEditorPane.spec.ts › mod editor pane behavior
chrome › tests/pageEditor/saveMod.spec.ts › can save a new trigger mod
msedge › tests/regressions/hideModalsOnPageEditorRefresh.spec.ts › should hide add brick modal when Page Editor refreshes

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

[fungairino]

nit: why "0.0.0" vs "1.0.0"?

It seems like we do this defaulting logic in a couple of different places so it might be worth looking into if we can make this a non-optional field upstream.

[twschiller]

nit: why "0.0.0" vs "1.0.0"?

So on the backend it's easier to see if it's defaulted or not

It seems like we do this defaulting logic in a couple of different places so it might be worth looking into if we can make this a non-optional field upstream.

I agree - see the future work ticket calling out fixing the upstream types. The change was too large to make on short turnaround

[github-actions]

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.10%. Comparing base (8318d74) to head (c7c6627).
Report is 352 commits behind head on main.

Files with missing lines	Patch %	Lines
src/utils/deploymentUtils.ts	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9258      +/-   ##
==========================================
+ Coverage   74.24%   75.10%   +0.85%     
==========================================
  Files        1332     1370      +38     
  Lines       40817    42302    +1485     
  Branches     7634     7892     +258     
==========================================
+ Hits        30306    31769    +1463     
- Misses      10511    10533      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.