Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure path is set when opening the sidebar #8452

Merged
merged 3 commits into from
May 13, 2024
Merged

Conversation

fungairino
Copy link
Collaborator

@fungairino fungairino commented May 13, 2024

What does this PR do?

This PR addresses a rare issue in the Pixiebrix extension where the side panel does not open as expected. The fix involves setting the path again in the openSidePanelMv3 function within the sidePanelUtils.ts file.

I suspect that this happens when the tab is replaced but we don't rerun the onCreated listener in the trigger for some reason, but I can't say for sure.

I verified this fix by pausing the debugger in an affected tab, and running the same code with the path set, and then the sidebar opened.

See: https://pixiebrix.slack.com/archives/C0436P48QHY/p1715608128610539

Checklist

  • Add jest or playwright tests and/or storybook stories
  • Designate a primary reviewer @grahamlangford

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.42%. Comparing base (6d95047) to head (dfe39ad).
Report is 57 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8452      +/-   ##
==========================================
- Coverage   73.47%   73.42%   -0.05%     
==========================================
  Files        1334     1352      +18     
  Lines       41259    41523     +264     
  Branches     7686     7778      +92     
==========================================
+ Hits        30316    30490     +174     
- Misses      10943    11033      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 13, 2024

Playwright test results - MV2

passed  41 passed
flaky  1 flaky
skipped  8 skipped

Details

report  Open report ↗︎
stats  50 tests across 18 suites
duration  10 minutes, 12 seconds
commit  dfe39ad

Flaky tests

edge › tests/extensionConsoleActivation.spec.ts › can activate a mod with a database

Skipped tests

chrome › tests/extensionConsoleActivation.spec.ts › can activate a mod with built-in integration
edge › tests/extensionConsoleActivation.spec.ts › can activate a mod with built-in integration
chrome › tests/runtime/sidebarController.spec.ts › sidebar controller › shows focus dialog in top-level frame
edge › tests/runtime/sidebarController.spec.ts › sidebar controller › shows focus dialog in top-level frame
chrome › tests/runtime/sidebarNavigation.spec.ts › sidebar mod panels are persistent during navigation
chrome › tests/runtime/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation
edge › tests/runtime/sidebarNavigation.spec.ts › sidebar mod panels are persistent during navigation
edge › tests/runtime/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation

Copy link

github-actions bot commented May 13, 2024

Playwright test results - MV3

passed  48 passed
flaky  2 flaky

Details

report  Open report ↗︎
stats  50 tests across 18 suites
duration  14 minutes, 28 seconds
commit  dfe39ad

Flaky tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
edge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor

@twschiller twschiller added the bug Something isn't working label May 13, 2024
@fungairino fungairino merged commit a7a573e into main May 13, 2024
20 checks passed
@fungairino fungairino deleted the sidebar-not-open branch May 13, 2024 17:20
@twschiller twschiller added this to the 2.0.0 milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

3 participants