-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure path is set when opening the sidebar #8452
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8452 +/- ##
==========================================
- Coverage 73.47% 73.42% -0.05%
==========================================
Files 1334 1352 +18
Lines 41259 41523 +264
Branches 7686 7778 +92
==========================================
+ Hits 30316 30490 +174
- Misses 10943 11033 +90 ☔ View full report in Codecov by Sentry. |
Playwright test results - MV2Details Open report ↗︎ Flaky testsedge › tests/extensionConsoleActivation.spec.ts › can activate a mod with a database Skipped testschrome › tests/extensionConsoleActivation.spec.ts › can activate a mod with built-in integration |
Playwright test results - MV3Details Open report ↗︎ Flaky testschrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor |
What does this PR do?
This PR addresses a rare issue in the Pixiebrix extension where the side panel does not open as expected. The fix involves setting the path again in the
openSidePanelMv3
function within thesidePanelUtils.ts
file.I suspect that this happens when the tab is replaced but we don't rerun the onCreated listener in the trigger for some reason, but I can't say for sure.
I verified this fix by pausing the debugger in an affected tab, and running the same code with the path set, and then the sidebar opened.
See: https://pixiebrix.slack.com/archives/C0436P48QHY/p1715608128610539
Checklist