-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SandboxTimeoutError metadata to error message instead of extra properties #9262
Add SandboxTimeoutError metadata to error message instead of extra properties #9262
Conversation
Playwright test resultsDetails Open report ↗︎ Flaky testschrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod Skipped testschrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor |
To follow-up with Datadog, I created this issue: DataDog/browser-sdk#3067 |
We should consider modifying |
Agreed, although I'm not 100% sure how we'd design it in a situation like this where we want to add extra properties to a deeply nested error stack |
Great idea, thanks for doing that |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main pixiebrix/pixiebrix-extension#9262 +/- ##
==========================================
+ Coverage 74.24% 75.09% +0.85%
==========================================
Files 1332 1369 +37
Lines 40817 42264 +1447
Branches 7634 7882 +248
==========================================
+ Hits 30306 31740 +1434
- Misses 10511 10524 +13 ☔ View full report in Codecov by Sentry. |
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
What does this PR do?