-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8428: playwright activating a quick bar mod when you dont have a quick bar shortcut configured #8429
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8429 +/- ##
==========================================
- Coverage 73.47% 73.41% -0.06%
==========================================
Files 1334 1352 +18
Lines 41259 41523 +264
Branches 7686 7778 +92
==========================================
+ Hits 30316 30486 +170
- Misses 10943 11037 +94 ☔ View full report in Codecov by Sentry. |
Playwright test results - MV2Details Open report ↗︎ Flaky testschrome › tests/extensionConsoleActivation.spec.ts › can activate a mod with a database Skipped testschrome › tests/extensionConsoleActivation.spec.ts › can activate a mod with built-in integration |
Playwright test results - MV3Details Open report ↗︎ Flaky testschrome › tests/pageEditor/saveMod.spec.ts › can save a standalone trigger mod |
…hen-you-dont-have-a-quick-bar-shortcut-configured
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opportunity to refactor runModViaQuickbar
in this file, which currently works by trying both modifier keys
…hen-you-dont-have-a-quick-bar-shortcut-configured
What does this PR do?
Checklist