Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8428: playwright activating a quick bar mod when you dont have a quick bar shortcut configured #8429

Conversation

grahamlangford
Copy link
Collaborator

What does this PR do?

Checklist

  • Add jest or playwright tests and/or storybook stories
  • Designate a primary reviewer @fungairino

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.41%. Comparing base (6d95047) to head (521e665).
Report is 59 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8429      +/-   ##
==========================================
- Coverage   73.47%   73.41%   -0.06%     
==========================================
  Files        1334     1352      +18     
  Lines       41259    41523     +264     
  Branches     7686     7778      +92     
==========================================
+ Hits        30316    30486     +170     
- Misses      10943    11037      +94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 9, 2024

Playwright test results - MV2

passed  42 passed
flaky  2 flaky
skipped  8 skipped

Details

report  Open report ↗︎
stats  52 tests across 18 suites
duration  11 minutes, 10 seconds
commit  521e665

Flaky tests

chrome › tests/extensionConsoleActivation.spec.ts › can activate a mod with a database
edge › tests/extensionConsoleActivation.spec.ts › can activate a mod with a database

Skipped tests

chrome › tests/extensionConsoleActivation.spec.ts › can activate a mod with built-in integration
edge › tests/extensionConsoleActivation.spec.ts › can activate a mod with built-in integration
chrome › tests/runtime/sidebarController.spec.ts › sidebar controller › shows focus dialog in top-level frame
edge › tests/runtime/sidebarController.spec.ts › sidebar controller › shows focus dialog in top-level frame
chrome › tests/runtime/sidebarNavigation.spec.ts › sidebar mod panels are persistent during navigation
chrome › tests/runtime/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation
edge › tests/runtime/sidebarNavigation.spec.ts › sidebar mod panels are persistent during navigation
edge › tests/runtime/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation

Copy link

github-actions bot commented May 9, 2024

Playwright test results - MV3

passed  49 passed
flaky  3 flaky

Details

report  Open report ↗︎
stats  52 tests across 18 suites
duration  15 minutes, 55 seconds
commit  521e665

Flaky tests

chrome › tests/pageEditor/saveMod.spec.ts › can save a standalone trigger mod
chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
edge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor

…hen-you-dont-have-a-quick-bar-shortcut-configured
Copy link

github-actions bot commented May 9, 2024

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

Copy link
Collaborator

@mnholtz mnholtz May 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opportunity to refactor runModViaQuickbar in this file, which currently works by trying both modifier keys

…hen-you-dont-have-a-quick-bar-shortcut-configured
@grahamlangford grahamlangford merged commit ea685dc into main May 13, 2024
19 checks passed
@grahamlangford grahamlangford deleted the 8428-playwright-activating-a-quick-bar-mod-when-you-dont-have-a-quick-bar-shortcut-configured branch May 13, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Playwright: Activating a quick bar mod when you don’t have a quick bar shortcut configured
4 participants