Animation beta #1341
Merged
Animation beta #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2f09d71.
I was probably quite sleepy when working on the restHipsPosition procedure last time See: c11d6e9
fix: Fix the issue that hips translation goes infinity
not a proper typing, might want to fix from three-ts-types side
- Bump three-vrm to v2.0.8 - Set light intensity to PI Co-authored-by: ke456-png <108649297+ke456-png@users.noreply.github.com>
GitHub provenance failed because of this
setFromRotationMatrix don't work with world matrices with scales replaced with decompose
ke456-png
approved these changes
Feb 14, 2024
0b5vr
force-pushed
the
animation-beta
branch
from
4701403 to
155382e
Compare
Also add a specVersion gate which only passes "1.0" and "1.0-draft"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch manages the beta release of three-vrm which contains VRM animation features.
It will be merged into
devonce VRM animation spec is released.