fix: Fix screenCoordinates outline rendering in WebGL #1492
Conversation
I suspect that we will have an issue that outline does not appear in r169 WebGPURenderer Also I spotted a bug in WebGL outline when the mode is screenCoordinates
0b5vr
added
bug
This was because this line fails if we load both And this easily happens when we write our importmap in this way: <script type="importmap">
{
"imports": {
"three": "https://cdn.jsdelivr.net/npm/three@0.168.0/build/three.module.js",
"three/webgpu": "https://cdn.jsdelivr.net/npm/three@0.168.0/build/three.webgpu.js",
// ...
}
}
</script>maybe we should consider changing the |
| outlineTex = texture2D( outlineWidthMultiplyTexture, outlineWidthMultiplyTextureUv ).g; | ||
| #endif | ||
|
|
||
| #ifdef OUTLINE_WIDTH_WORLD |
There was a problem hiding this comment.
so OUTLINE_WIDTH_WORLD is no longer needed?
There was a problem hiding this comment.
Yes, while I agree that it is too implicit to acknowledge that OUTLINE && !OUTLINE_WIDTH_SCREEN == OUTLINE_WIDTH_WORLD.
There was a problem hiding this comment.
Ended up removing the line @ 1426a61
There was a problem hiding this comment.
Maybe leave a comment or something in shader code would help future us? Anyway LGTM.
| vec2 projectedNormal = normalize( clipNormal.xy ); | ||
| projectedNormal.x *= projectionMatrix[ 0 ].x / projectionMatrix[ 1 ].y; | ||
| gl_Position.xy += 2.0 * outlineWidthFactor * outlineTex * projectedNormal.xy; | ||
| outlineOffset *= vViewPosition.z / projectionMatrix[ 1 ].y; |
There was a problem hiding this comment.
outlineOffset has been fixed and using the same logic in tsl
Description
feature-test.htmlandwebgpu-feature-test.html.screenCoordinatesoutline in WebGL.The screenshot of the new
feature-test.html: