Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PythonCompatUpdate for lua and ruby, too #304

Closed
juippis opened this issue Mar 11, 2021 · 3 comments · Fixed by #595
Closed

PythonCompatUpdate for lua and ruby, too #304

juippis opened this issue Mar 11, 2021 · 3 comments · Fixed by #595
Assignees
Labels

Comments

@juippis
Copy link

juippis commented Mar 11, 2021

This just popped to my mind and I wanted to let it out somewhere and you were not in IRC.

I didn't see duplicate for this, nor it being documented in https://pkgcore.github.io/pkgcheck/man/pkgcheck.html yet.

@arthurzam
Copy link
Member

While I agree with the idea, and it is quite simple to add, I have asked people of lua & ruby projects if they would like that, and in multiple times they rejected it.

@arthurzam arthurzam closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2023
@juippis
Copy link
Author

juippis commented Jan 24, 2023

Thanks for trying!

@thesamesam
Copy link
Member

thesamesam commented Mar 20, 2023

I don't know if it makes sense for Lua because Lua often requires proper porting between versions, but for Python and Ruby, it's largely a function of whether one's deps are ready + usually a small amount of porting work in the package itself, if any.

I think the check at least is well-defined for Ruby, even if we don't enable it by default. I'd find this pretty useful over having to do what we used to for Python - manually adding to PYTHON_COMPAT, then running pkgcheck scan to look for dep errors.

I have a draft of it for Ruby.

@thesamesam thesamesam reopened this Mar 20, 2023
@arthurzam arthurzam pinned this issue Jun 21, 2023
@arthurzam arthurzam self-assigned this Jun 29, 2023
arthurzam added a commit to arthurzam/pkgcheck that referenced this issue Jun 29, 2023
Resolves: pkgcore#304
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
@arthurzam arthurzam unpinned this issue Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants