RubyCompatCheck: new check for new USE_RUBY compatible values #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #595 +/- ##
==========================================
- Coverage 79.88% 79.70% -0.19%
==========================================
Files 57 58 +1
Lines 8545 8602 +57
Branches 1941 1956 +15
==========================================
+ Hits 6826 6856 +30
- Misses 1618 1643 +25
- Partials 101 103 +2
☔ View full report in Codecov by Sentry. |
thesamesam
reviewed
Jun 29, 2023
Resolves: pkgcore#304 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
thesamesam
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the
ruby-ng.eclassis a real abomination I've created. I've extracted parts from real ruby-ng, modified as I needed, took shortcuts and more. I hope no sane person will use this abomination, we need to cast in into the fire :)Resolves: #304