Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MissingRemoteId: MissingRemoteId: expand gitlab matching rules #637

Closed
wants to merge 1 commit into from
Closed

MissingRemoteId: MissingRemoteId: expand gitlab matching rules #637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/pkgcheck/checks/metadata_xml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,9 @@ class MissingRemoteIdCheck(Check):
_source = sources.PackageRepoSource
known_results = frozenset([MissingRemoteId])

_gitlab_match = r"(?P<value>(\w[^/]*/)*\w[^/]*/\w[^/]*)"
# Exclude api groups and raw project names to conform with https://docs.gitlab.com/ee/user/reserved_names.html
# with the URI's which are most likely to end up in SRC_URI
_gitlab_match = r"(?P<value>((?!api/)\w[^/]*/)+(?!raw/)\w[^/]*)"

remotes_map = (
("bitbucket", r"https://bitbucket.org/(?P<value>[^/]+/[^/]+)"),
Expand Down