MissingRemoteId: MissingRemoteId: expand gitlab matching rules #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
parona-source
force-pushed
the
gitlab_remoteid
branch
from
6d86388 to
be91dec
Compare
parona-source
changed the title
|
Changed approach to include the reserved words in the regex. The other notable change to the regex is that I simplified it in addition of complicating it. Went with the idea of "one of more group name match followed by one project name match" rather than "one group name match, followed by zero or more group name matches and one project name match". Made it simpler to include the rules for reserved names. |
parona-source
force-pushed
the
gitlab_remoteid
branch
from
be91dec to
7d545db
Compare
* Notably handles the particular case with gitlab package hosting. Bug: pkgcore#636 Signed-off-by: Alfred Wingate <parona@protonmail.com>
parona-source
force-pushed
the
gitlab_remoteid
branch
from
7d545db to
1bc4b0c
Compare
|
Pushed as discussed on IRC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: #636