Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1 #210

Merged
merged 2 commits into from
Dec 12, 2023
Merged

V1 #210

merged 2 commits into from
Dec 12, 2023

Conversation

mxcl
Copy link
Member

@mxcl mxcl commented Nov 29, 2023

No description provided.

@mxcl
Copy link
Member Author

mxcl commented Nov 29, 2023

an issue here is that test is not an ok name for a binary in the PATH since the shell built in always claims it.

So we will need another verb or to make them all subcommands again.

@jhheider
Copy link
Contributor

So we will need another verb or to make them all subcommands again.

-x suffix?
buildx, testx, cleanx (lol).

@mxcl mxcl force-pushed the v1 branch 4 times, most recently from 26f5bba to 70b0d61 Compare December 1, 2023 19:17
@mxcl
Copy link
Member Author

mxcl commented Dec 4, 2023

So we will need another verb or to make them all subcommands again.

-x suffix? buildx, testx, cleanx (lol).

gone with bk build, bk test.

@jhheider
Copy link
Contributor

jhheider commented Dec 4, 2023

image

@mxcl mxcl force-pushed the v1 branch 4 times, most recently from 1e7a1a3 to 62e7128 Compare December 10, 2023 17:59
@mxcl mxcl force-pushed the v1 branch 2 times, most recently from bc14e9b to 97fb9dd Compare December 12, 2023 17:27
@mxcl
brewkit v1
9628735 
* rewrite in mostly TypeScript
* `pkg` -> `bk` to avoid confusion with `pkgx`
* proper actions
* pkgx pantry specific infra moved to pantry
* irrelevant commands removed to be put into `mash`
* changes are now fully tested in CI without needing pkgx pantry packages
* Fixes #173
* builds occur to separate prefix to aid relocatability testing (Fixes #166)
* Refs #160
* Fixes #158
* Fixes #157
* Fixes #129
* Fixes #117 (though I didn’t explicitly fix this we have a fixture showing this working now)
* Feat: initializes a git repo in the sources so you can easily get a diff for your build script
jhheider
jhheider reviewed Dec 12, 2023
View reviewed changes
share/.DS_Store Outdated Show resolved Hide resolved
jhheider
jhheider reviewed Dec 12, 2023
View reviewed changes
bin/cmd/docker Outdated Show resolved Hide resolved
jhheider
jhheider approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@jhheider jhheider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. fewer shell scripts means fewer weird shell script bugs.

@mxcl mxcl merged commit e7251b9 into main Dec 12, 2023
24 checks passed
@mxcl mxcl deleted the v1 branch December 12, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhheider jhheider jhheider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxcl @jhheider