Address build errors for Ubuntu 22.04 (#1090)

* Address build errors for Ubuntu 22.04 When calling `JSObjectCallAsFunction`, the `arguments` parameter should be `NULL` when the `argumentCount` parameter is 0. But... we were passing an empty array for the `arguments` parameter. There is something new/different in Ubuntu 22.04 that raises a warning around this. Closes #1089 * CHANGELOG update
planck-repl · May 13, 2022 · 078c52e · 078c52e
1 parent f1f21bf
commit 078c52e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@ All notable changes to this project will be documented in this file. This change
 ## [Unreleased]
 ### Fixed
 - Build issue with `sed` on Ubuntu ([#1084](https://github.com/planck-repl/planck/issues/1084))
+- Address build errors on Ubuntu 22.04 ([#1089](https://github.com/planck-repl/planck/issues/1089))
 
 ## [2.26.0] - 2022-02-12
 ### Changed

diff --git a/planck-c/engine.c b/planck-c/engine.c
@@ -351,15 +351,13 @@ char *get_current_ns() {
         return NULL;
     }
 
-    size_t num_arguments = 0;
-    JSValueRef arguments[num_arguments];
     static JSObjectRef get_current_ns_fn = NULL;
     if (!get_current_ns_fn) {
         get_current_ns_fn = get_function("planck.repl", "get-current-ns");
         JSValueProtect(ctx, get_current_ns_fn);
     }
-    JSValueRef result = JSObjectCallAsFunction(ctx, get_current_ns_fn, JSContextGetGlobalObject(ctx), num_arguments,
-                                               arguments, NULL);
+    JSValueRef result = JSObjectCallAsFunction(ctx, get_current_ns_fn, JSContextGetGlobalObject(ctx), 0,
+                                               NULL, NULL);
     return value_to_c_string(ctx, result);
 }
 
@@ -413,10 +411,9 @@ void discarding_sender(const char *msg) {
 
 void maybe_load_user_file() {
     if (config.repl) {
-        JSValueRef arguments[0];
         JSValueRef ex = NULL;
         JSObjectCallAsFunction(ctx, get_function("planck.repl", "maybe-load-user-file"), JSContextGetGlobalObject(ctx),
-                               0, arguments, &ex);
+                               0, NULL, &ex);
         debug_print_value("planck.repl/maybe-load-user-file", ctx, ex);
 
         if (ex) {
@@ -426,10 +423,9 @@ void maybe_load_user_file() {
 }
 
 void init_paredit(JSContextRef ctx) {
-    JSValueRef arguments[0];
     JSValueRef ex = NULL;
     JSObjectCallAsFunction(ctx, get_function("planck.repl", "init-paredit"),
-                           JSContextGetGlobalObject(ctx), 0, arguments, &ex);
+                           JSContextGetGlobalObject(ctx), 0, NULL, &ex);
 
     if (ex) {
         print_value("Error initializing paredit: ", ctx, ex);
@@ -679,10 +675,9 @@ void *do_engine_init(void *data) {
 
     set_print_sender(NULL);
 
-    JSValueRef arguments[0];
     JSValueRef ex = NULL;
     JSObjectCallAsFunction(ctx, get_function("planck.repl", "init-data-readers"), JSContextGetGlobalObject(ctx), 0,
-                           arguments, &ex);
+                           NULL, &ex);
 
     if (ex) {
         print_value("Error initializing data readers: ", ctx, ex);