-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build errors under Ubuntu 22.04 #1089
Comments
lread
added a commit
to lread/planck
that referenced
this issue
May 2, 2022
When calling `JSObjectCallAsFunction`, the `arguments` parameter should be `NULL` when the `argumentCount` parameter is 0. But... we were passing an empty array for the `arguments` parameter. There is something new/different in Ubuntu 22.04 that raises a warning around this. Closes planck-repl#1089
lread
added a commit
to lread/planck
that referenced
this issue
May 2, 2022
When calling `JSObjectCallAsFunction`, the `arguments` parameter should be `NULL` when the `argumentCount` parameter is 0. But... we were passing an empty array for the `arguments` parameter. There is something new/different in Ubuntu 22.04 that raises a warning around this. Closes planck-repl#1089
mfikes
pushed a commit
that referenced
this issue
May 13, 2022
* Address build errors for Ubuntu 22.04 When calling `JSObjectCallAsFunction`, the `arguments` parameter should be `NULL` when the `argumentCount` parameter is 0. But... we were passing an empty array for the `arguments` parameter. There is something new/different in Ubuntu 22.04 that raises a warning around this. Closes #1089 * CHANGELOG update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While looking at #1087, I noticed the following while running
script/build -Werror --fast
against planck master on Ubuntu 22.04:And this note that
arguments
should be NULL when argumentCount is 0:And things do pass after correcting this on Ubuntu 22, but still seg fault on Ubuntu 20.
Originally posted by @lread in #1087 (comment)
Since Ubuntu 22.04 has been officially released, probably a good idea to address.
I'll follow up with a PR.
The text was updated successfully, but these errors were encountered: