Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SwiftLint] Upgrade SwiftLint and new rules #164

Merged
merged 3 commits into from
Apr 29, 2019
Merged

Conversation

anayini
Copy link
Contributor

@anayini anayini commented Apr 24, 2019

This commit upgrades to the latest version of SwiftLint, adds
several new rules and corrects the codebase.

Changes in this pull request

Issue fixed: #160

Checklist

  • All tests pass. Demo project builds and runs.
  • I added tests, an experiment, or detailed why my change isn't tested.
  • I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
  • I have reviewed the contributing guide

This commit upgrades to the latest version of SwiftLint, adds
several new rules and corrects the codebase.
Copy link
Contributor

@jessesquires jessesquires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@anayini anayini marked this pull request as ready for review April 28, 2019 23:19
@PlanBot-iOS
Copy link

PlanBot-iOS commented Apr 28, 2019

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@anayini anayini added this to the Next milestone Apr 28, 2019
@jessesquires jessesquires merged commit 81b65fa into master Apr 29, 2019
@jessesquires jessesquires deleted the add-swiftlint-rules branch April 29, 2019 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lint] Update / add new SwiftLint rules
3 participants