[SwiftLint] Upgrade SwiftLint and new rules

.swiftlint.yml

@@ -21,21 +21,42 @@ opt_in_rules:
   - first_where
   - sorted_first_last
   - contains_over_first_not_nil
+  - last_where
+
 
   # idiomatic
   - fatal_error_message
+  - xctfail_message
+  - legacy_random
+  - no_extension_access_modifier
+  - redundant_type_annotation
+  - toggle_bool
 
   # style
   - number_separator
   - operator_usage_whitespace
   - sorted_imports
-  - redundant_type_annotation
+  - redundant_objc_attribute
   - closure_spacing
   - collection_alignment
-  - toggle_bool
+  - modifier_order
+  - vertical_whitespace_closing_braces
+  - multiline_arguments
+  - multiline_parameters
+  - unneeded_parentheses_in_closure_argument
+  - explicit_self
 
   # lint
   - overridden_super_call
+  - yoda_condition
+  - weak_computed_property
+  - anyobject_protocol
+  - array_init
+  - empty_xctest_method
+  - identical_operands
+  - prohibited_super_call
+  - unused_import
+  - unused_private_declaration
 
 file_length: 650
 line_length: 200

CHANGELOG.md

@@ -8,6 +8,7 @@ NEXT
 ----
 
 ### Changed
+- Upgrades SwiftLint to 0.31.0 and add several new rules. ([#164](https://github.com/plangrid/ReactiveLists/pull/164), [@anayini](https://github.com/anayini))
 - Upgrade Travis to Xcode 10.2, SDK 12.2
 
 0.5.1

Example/Models.swift

@@ -26,7 +26,7 @@ struct Tool {
     let uuid = UUID()
 
     static func randomTool() -> Tool {
-        let randomNumber = arc4random_uniform((UInt32(ToolType.allValues.count)))
+        let randomNumber = UInt32.random(in: 0..<UInt32(ToolType.allValues.count))
         return Tool(type: ToolType(rawValue: randomNumber)!)
     }
 }
@@ -68,6 +68,5 @@ enum ToolType: UInt32 {
         case .crane:
             return "🏗️"
         }
-
     }
 }

Example/ToolTableViewCell.swift

@@ -17,5 +17,4 @@
 import UIKit
 
 final class ToolTableViewCell: UITableViewCell {
-
 }

Podfile

@@ -8,7 +8,7 @@ target 'ReactiveLists' do
     project 'ReactiveLists.xcodeproj'
 
     pod 'DifferenceKit', '1.1.0'
-    pod 'SwiftLint', '0.30.1'
+    pod 'SwiftLint', '0.31.0'
 
     target 'ReactiveListsExample' do
       project 'ReactiveLists.xcodeproj'

Podfile.lock

@@ -5,11 +5,11 @@ PODS:
   - DifferenceKit/Core (1.1.0)
   - DifferenceKit/UIKitExtension (1.1.0):
     - DifferenceKit/Core
-  - SwiftLint (0.30.1)
+  - SwiftLint (0.31.0)
 
 DEPENDENCIES:
   - DifferenceKit (= 1.1.0)
-  - SwiftLint (= 0.30.1)
+  - SwiftLint (= 0.31.0)
 
 SPEC REPOS:
   https://github.com/cocoapods/specs.git:
@@ -18,8 +18,8 @@ SPEC REPOS:
 
 SPEC CHECKSUMS:
   DifferenceKit: 7726ceeff4ec3748788e4b01396861b283797440
-  SwiftLint: a54bf1fe12b55c68560eb2a7689dfc81458508f7
+  SwiftLint: 7a0227733d786395817373b2d0ca799fd0093ff3
 
-PODFILE CHECKSUM: f4d525d7ba27317176274dd214708a367af86650
+PODFILE CHECKSUM: 74334aebd16efb052743e4dd7a9876efeb76d4eb
 
-COCOAPODS: 1.7.0.beta.3
+COCOAPODS: 1.6.0

Sources/CollectionViewModel.swift

@@ -38,16 +38,16 @@ public protocol CollectionCellViewModel: ReusableCellViewModelProtocol, Diffable
 }
 
 /// Default implementations for `CollectionCellViewModel`.
-public extension CollectionCellViewModel {
+extension CollectionCellViewModel {
 
     /// Default implementation, returns `true`.
-    var shouldHighlight: Bool { return true }
+    public var shouldHighlight: Bool { return true }
 
     /// Default implementation, returns `nil`.
-    var didSelect: DidSelectClosure? { return nil }
+    public var didSelect: DidSelectClosure? { return nil }
 
     /// Default implementation, returns `nil`.
-    var didDeselect: DidDeselectClosure? { return nil }
+    public var didDeselect: DidDeselectClosure? { return nil }
 }
 
 /// View model for supplementary views in collection views.
@@ -66,13 +66,13 @@ public protocol CollectionSupplementaryViewModel: ReusableSupplementaryViewModel
 }
 
 /// Default implementations for `CollectionViewSupplementaryViewModel`.
-public extension CollectionSupplementaryViewModel {
+extension CollectionSupplementaryViewModel {
 
     /// Default implementation, returns `nil`.
-    var viewInfo: SupplementaryViewInfo? { return nil }
+    public var viewInfo: SupplementaryViewInfo? { return nil }
 
     /// Default implementation, returns `nil`.
-    var height: CGFloat? { return nil }
+    public var height: CGFloat? { return nil }
 }
 
 /// The view model that describes a `UICollectionView`.

Sources/Diffing.swift

@@ -34,10 +34,10 @@ public protocol DiffableViewModel {
 public typealias DiffingKey = String
 
 /// Default value for diffingKey
-public extension DiffableViewModel {
+extension DiffableViewModel {
 
     /// Default implementation. Uses class name.
-    var diffingKey: DiffingKey {
+    public var diffingKey: DiffingKey {
         return String(describing: Self.self)
     }
 }

Sources/TableViewModel.swift

@@ -56,38 +56,38 @@ public protocol TableCellViewModel: ReusableCellViewModelProtocol, DiffableViewM
 }
 
 /// Default implementations for `TableCellViewModel`.
-public extension TableCellViewModel {
+extension TableCellViewModel {
 
     /// Default implementation, returns `nil`.
     /// - Note: If `nil`, the `TableViewDriver` will fallback to `TableViewModel.defaultRowHeight`.
     /// - See also: TableViewModel
-    var rowHeight: CGFloat? {
+    public var rowHeight: CGFloat? {
         return nil
     }
 
     /// Default implementation, returns `.none`.
-    var editingStyle: UITableViewCell.EditingStyle { return .none }
+    public var editingStyle: UITableViewCell.EditingStyle { return .none }
 
     /// Default implementation, returns `true`.
-    var shouldHighlight: Bool { return true }
+    public var shouldHighlight: Bool { return true }
 
     /// Default implementation, returns `false`.
-    var shouldIndentWhileEditing: Bool { return false }
+    public var shouldIndentWhileEditing: Bool { return false }
 
     /// Default implementation, returns `nil`.
-    var willBeginEditing: WillBeginEditingClosure? { return nil }
+    public var willBeginEditing: WillBeginEditingClosure? { return nil }
 
     /// Default implementation, returns `nil`.
-    var didEndEditing: DidEndEditingClosure? { return nil }
+    public var didEndEditing: DidEndEditingClosure? { return nil }
 
     /// Default implementation, returns `nil`.
-    var commitEditingStyle: CommitEditingStyleClosure? { return nil }
+    public var commitEditingStyle: CommitEditingStyleClosure? { return nil }
 
     /// Default implementation, returns `nil`.
-    var didSelect: DidSelectClosure? { return nil }
+    public var didSelect: DidSelectClosure? { return nil }
 
     /// Default implementation, returns `nil`.
-    var accessoryButtonTapped: AccessoryButtonTappedClosure? { return nil }
+    public var accessoryButtonTapped: AccessoryButtonTappedClosure? { return nil }
 }
 
 /// Protocol that needs to be implemented by table view cell view models

Tests/TableView/TableViewMocks.swift

@@ -43,7 +43,7 @@ class TestTableView: UITableView {
     }
 
     override var indexPathsForVisibleRows: [IndexPath]? {
-        return (0..<self.numberOfSections).flatMap { (section) -> [IndexPath] in
+        return (0..<self.numberOfSections).flatMap { section -> [IndexPath] in
             (0..<self.numberOfRows(inSection: section)).map { IndexPath(row: $0, section: section) }
         }
     }