chg: Updated todo example to show tag usage #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barakalon
suggested changes
Feb 12, 2019
There was a problem hiding this comment.
Hi @kazamatzuri ! Thank's for the PR - I'm excited to see this.
This example serves the purpose of showing off some of the more advanced features of flask-rebar that are too cumbersome to add to the example on the README. I think tags are a good addition! As mentioned in a comment, I think we should specify only a single tag, so we can show how they work without distracting too much from the other features being demonstrated here.
Also, one more thing: there is a script, examples/todo/generate_output.py. It generates the examples/todo/todo_output.md file. Can you run that?
barakalon
reviewed
Feb 15, 2019
barakalon
approved these changes
Feb 15, 2019
barakalon
reviewed
Feb 15, 2019
|
Sweet 👍 ! |
twosigmajab
approved these changes
Feb 16, 2019
Closed
ghost
assigned 
RookieRick
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
to familiarize myself with this I updated the todo example with the tag usage that was added in #55.
Hope that's going to be helpful to someone.
Comments?
Thanks!
-Fab