Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforcing black #67

Closed
wants to merge 6 commits into from
Closed

Enforcing black #67

wants to merge 6 commits into from

Conversation

kazamatzuri
Copy link
Contributor

As discussed in #60 adding pre-commit config for black.
You will need to have pre-commit installed on your environment for this to work (and black).

(this is gonna be easier to merge once #59 is through )

@kazamatzuri kazamatzuri requested a review from a team as a code owner February 23, 2019 00:17
@ghost ghost assigned jordannielson Feb 23, 2019
@RookieRick
Copy link
Contributor

Am I correct in my understanding that this PR is superseded by #68 and should just be closed now?
Have tested after merging 68 and confirmed that:

  1. If a developer follows the instructions and installs pre-commit script, Git and black will do their thing when they try to commit, and
  2. If a dev doesn't install pre-commit script, Travis-CI will fail PR if black test fails.
    Huzzah!

@juliusiv
Copy link
Contributor

@RookieRick yep, this can be closed now. Thanks @kazamatzuri for getting this started!

@RookieRick RookieRick closed this Feb 26, 2019
@kazamatzuri kazamatzuri deleted the enforcing-black branch February 26, 2019 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants