Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version information for all the components in machine spec #81

Merged
merged 3 commits into from
Aug 7, 2018

Conversation

puneetguptanitj
Copy link
Contributor

@puneetguptanitj puneetguptanitj commented Aug 4, 2018

Add support for adding version information for all the components and subcomponents in the machine spec. Will be required by actuator to determine which versions of components to use
Example state file

 machineList:                                                                                                                                                                                                 
   items:                                                                                                                                                                                                     
   - apiVersion: cluster.k8s.io/v1alpha1                                                                                                                                                                      
     kind: Machine                                                                                                                                                                                            
     metadata:                                                                                                                                                                                                
       creationTimestamp: "2018-08-04T19:49:15Z"                                                                                                                                                              
       name: 1.2.3.4                                                                                                                                                                                          
       namespace: default                                                                                                                                                                                     
     spec:                                                                                                                                                                                                    
       metadata:                                                                                                                                                                                              
         creationTimestamp: null                                                                                                                                                                              
       providerConfig:                                                                                                                                                                                        
         ValueFrom: null                                                                                                                                                                                      
         value:                                                                                                                                                                                               
           ComponentVersions:                                                                                                                                                                                 
             cniVersion: v0.6.0                                                                                                                                                                               
             etcdVersion: v3.3.8                                                                                                                                                                              
             etcdadmVersion: v0.0.1-alpha                                                                                                                                                                     
             flannelVersion: v0.10.0                                                                                                                                                                          
             keepalivedVersion: v2.0.4                                                                                                                                                                        
             kubernetesVersion: 1.10.4                                                                                                                                                                        
             nodeadmVersion: v0.0.1-alpha    

Depends on platform9/ssh-provider#39

@puneetguptanitj puneetguptanitj force-pushed the private/add-component-version-info branch from b6fc074 to 5f83067 Compare August 6, 2018 18:58
Copy link
Contributor

@dlipovetsky dlipovetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@puneetguptanitj puneetguptanitj merged commit 32ae72c into master Aug 7, 2018
@puneetguptanitj puneetguptanitj deleted the private/add-component-version-info branch August 9, 2018 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants