Add version information for various components #39
Conversation
puneetguptanitj
force-pushed
the
private/add-component-version-info
branch
from
b52538e to
8ea63cc
Compare
in MachineSpec
puneetguptanitj
force-pushed
the
private/add-component-version-info
branch
from
8ea63cc to
cd1bd32
Compare
| type MachineComponentVersions struct { | ||
| NodeadmVersion string | ||
| EtcdadmVersion string | ||
| KubernetesVersion string |
There was a problem hiding this comment.
How does KubernetesVersion relate to the upstream MachineSpec.Versions field, which itself contains Kubelet and ControlPlane versions.
There was a problem hiding this comment.
Currently it is a much bigger super set, but eventually, once we move nodeadm and etcdadm to use range of versions, we should be able to move them out from this set and also remove flannel and handle it as an addon, then i think it would match upstream more closely (with only addition of etcd version)
| @@ -154,6 +189,7 @@ func Convert_v1alpha1_MachineSpec_To_sshprovider_MachineSpec(in *MachineSpec, ou | |||
| func autoConvert_sshprovider_MachineSpec_To_v1alpha1_MachineSpec(in *sshprovider.MachineSpec, out *MachineSpec, s conversion.Scope) error { | |||
| out.Roles = *(*[]MachineRole)(unsafe.Pointer(&in.Roles)) | |||
There was a problem hiding this comment.
Can we work around/avoid using unsafe? I just noticed this and read up https://golang.org/pkg/unsafe/#Pointer.
There was a problem hiding this comment.
Thanks Arun for taking a look, looked into the generators that we use to generate these files, there seems to be a command line option to skipUnsafe https://github.com/kubernetes/code-generator/blob/3541780c0c718ff0c54cadd8401bfd6402886100/cmd/conversion-gen/args/args.go#L70, the default is false. Have created #40 to see if we can update our make build to use skipUnsafe as true
Add version information for various components in MachineSpec