Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change API container image to use jammy-chiseled-extra container image which includes ICU libraries #413

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

tjementum
Copy link
Member

Summary & Motivation

The Alpine container image used to deploy the API failed when running Entity Framework queries, with a CultureNotFoundException (see this GitHub Issue: dotnet/SqlClient#2239).

The root cause is that the SqlClient doesn't support invariant globalization.

The solution requires that the docker container has ICU libraries installed. Using a Dockerfile, this would be simple, but since we are using dotnet publish -t:PublishContainer ... we change the container image from alpine to jammy-chiseled-extra. Not a perfect solution as this image is bigger, and hence also has a bigger attack surface.

Checklist

  • I have added a Label to the pull-request
  • I have added tests, and done manual regression tests
  • I have updated the documentation, if necessary

@tjementum tjementum added the bug Something isn't working label Apr 9, 2024
Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tjementum tjementum merged commit 690617c into main Apr 9, 2024
8 checks passed
@tjementum tjementum deleted the change-docker-image-to-include-icu-libraries branch April 9, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants