Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGL related part GraphicsDevice is moving to a separate class #3993

Closed
wants to merge 5 commits into from

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Feb 7, 2022

Related to #3986

A base GraphicsDevice class is going to be platform independent, and WeblGraphicsDevice will contain WebGL specific implementation. In this first step, the whole implementation was simply moved to WeblGraphicsDevice.

@mvaligursky mvaligursky self-assigned this Feb 7, 2022
@mvaligursky mvaligursky requested a review from a team February 7, 2022 10:31
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Feb 7, 2022
@slimbuck
Copy link
Member

slimbuck commented Feb 9, 2022

Have you tried using git mv graphics-device.js webgl/blah ? Might keep better history this way.

@mvaligursky
Copy link
Contributor Author

Have you tried using git mv graphics-device.js webgl/blah ? Might keep better history this way.

I did, git mv and few different ways. Some of them work if you only move / rename file. But as soon as you modify it, the operation changes to delete/create pair. The suggestion online is to move / rename in a separate PR to the modify. But we cannot move files without modifying .. at least import paths.
I even created a test PR with two commits, first to move, second to change ..
#4007
when you inspect commits, there's perfect, the one with changes only shows small changes. But when you look at changed files for whole PR, the story is different :(

@mvaligursky
Copy link
Contributor Author

I'm also trying to split it into two separate PRs .. maybe that's a better way. Here: #4009
I moved graphics-device.js to webgl subfolder .. and it's seen as move, even when I fixed the import paths. So this might preserve the history better. So maybe I do this as a first step, and then do follow up refactor after #4009 is merged.

@mvaligursky
Copy link
Contributor Author

closing this one, as this has been done using two steps in order to preserve git history of GraphicsDevice:

@mvaligursky mvaligursky deleted the mvaligursky-webgl-graphics-device branch February 10, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants