Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of WebglGraphicsDevice class #4010

Merged
merged 3 commits into from
Feb 10, 2022
Merged

Initial implementation of WebglGraphicsDevice class #4010

merged 3 commits into from
Feb 10, 2022

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Feb 10, 2022 •
edited
Loading

This is a second step in making WebglGraphicsDevice class while preserving git history, after in the first step:
#4009

The base class GraphicsDevice is created, and WebglGraphicsDevice extends this.

@mvaligursky mvaligursky self-assigned this Feb 10, 2022
@mvaligursky mvaligursky requested a review from a team February 10, 2022 10:35
@mvaligursky mvaligursky mentioned this pull request Feb 10, 2022
Closed
@slimbuck
Copy link
Member

Awesome that you managed to keep history in tact!

With this change GraphicsDevice types & docs will go missing. What's the plan with that?

@mvaligursky
Copy link
Contributor Author

With this change GraphicsDevice types & docs will go missing. What's the plan with that?

Good point, and I'm addressing this on a separate branch / PR already, which should be ready very soon.

slimbuck
slimbuck approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@slimbuck slimbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but pls wait for @willeastcott to also approve before merging!

willeastcott
willeastcott approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@willeastcott willeastcott left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with comments. Note that I'm nervous about the next engine patch release - this is a pretty fundamental change.

@mvaligursky mvaligursky merged commit c2add69 into dev Feb 10, 2022
@mvaligursky mvaligursky deleted the mvaligursky-webgldevice-new branch February 10, 2022 12:27
@mvaligursky mvaligursky mentioned this pull request Feb 10, 2022
Merged
@mvaligursky mvaligursky mentioned this pull request Jul 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

@willeastcott willeastcott willeastcott approved these changes

Assignees

@mvaligursky mvaligursky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvaligursky @slimbuck @willeastcott