Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer update speedup #5758

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Buffer update speedup #5758

merged 2 commits into from
Oct 17, 2023

Conversation

slimbuck
Copy link
Member

When updating an existing GL buffer it is faster to call bufferSubData instead of bufferData (which creates a new gl-side buffer each time).

This change roughly halves the time taken to update splat buffers.

@slimbuck slimbuck added the area: graphics Graphics related issue label Oct 17, 2023
@slimbuck slimbuck requested a review from a team October 17, 2023 08:14
@slimbuck slimbuck self-assigned this Oct 17, 2023
@willeastcott
Copy link
Contributor

Wow, these are the kinds of speedups I ❤️

mvaligursky
mvaligursky approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change!

@slimbuck slimbuck merged commit d54b1df into playcanvas:main Oct 17, 2023
7 checks passed
@slimbuck slimbuck deleted the buffer-speedup branch October 17, 2023 08:52
@slimbuck slimbuck mentioned this pull request Oct 17, 2023
Merged
@thisredone thisredone mentioned this pull request Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaligursky mvaligursky mvaligursky approved these changes

@willeastcott willeastcott willeastcott approved these changes

Assignees

@slimbuck slimbuck

Labels
area: graphics Graphics related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slimbuck @willeastcott @mvaligursky