Disable antialiasing when running in Windows Firefox due to possible Firefox bug #5857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marklundin
approved these changes
Nov 27, 2023
slimbuck
reviewed
Nov 27, 2023
slimbuck
approved these changes
Nov 27, 2023
We don't know when this will be fixed. It's easier to put a stop version when we confirm the fix, vs patching the engine each time a new broken FF is released. |
Firefox 115 esr (basically longer term support) will also have this bug. |
mvaligursky
added a commit
that referenced
this pull request
Nov 28, 2023
…Firefox bug (#5857) * Disable antialiasing when running in Windows Firefox due to possible Firefox bug * types * only for firefox 120+ * updated to cover esr115 as well --------- Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a workaround for #5856 - disable AA on Windows Firefox
Only handling version 120+ based on userAgent:
When Firefox releases a fix, we'll need to adjust the condition to avoid the workaround from the fixed version.