Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable antialiasing when running in Windows Firefox due to possible Firefox bug #5857

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Disable antialiasing when running in Windows Firefox due to possible Firefox bug #5857

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
246f83c
Disable antialiasing when running in Windows Firefox due to possible …
Nov 27, 2023
2690320
types
Nov 27, 2023
69145be
only for firefox 120+
Nov 27, 2023
38b231e
updated to cover esr115 as well
Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/core/platform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,15 @@ const passiveEvents = detectPassiveEvents();
* }
*/
const platform = {
/**
* String identifying the current platform. Can be one of: android, ios, windows, osx, linux,
* cros or null.
*
* @type {string|null}
mvaligursky marked this conversation as resolved.
Show resolved Hide resolved
* @ignore
*/
name: platformName,

/**
* String identifying the current runtime environment. Either 'browser' or 'node'.
*
Expand Down
5 changes: 5 additions & 0 deletions src/platform/graphics/webgl/webgl-graphics-device.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,11 @@ class WebglGraphicsDevice extends GraphicsDevice {
Debug.log("Antialiasing has been turned off due to rendering issues on AppleWebKit 15.4");
}

// #5856 - turn off antialiasing on Windows Firefox
if (platform.browserName === 'firefox' && platform.name === 'windows') {
options.antialias = false;
}

let gl = null;

// we always allocate the default framebuffer without antialiasing, so remove that option
Expand Down