LightComponent properties port to get/set #6114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpal81xd
changed the title
willeastcott
reviewed
Mar 6, 2024
willeastcott
reviewed
Mar 6, 2024
willeastcott
reviewed
Mar 7, 2024
willeastcott
reviewed
Mar 7, 2024
willeastcott
reviewed
Mar 7, 2024
|
@willeastcott I just added a comment for when I update the component to remove that data method |
willeastcott
approved these changes
Mar 11, 2024
Co-authored-by: Will Eastcott <will@playcanvas.com>
Co-authored-by: Will Eastcott <will@playcanvas.com>
Co-authored-by: Will Eastcott <will@playcanvas.com>
mvaligursky
reviewed
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of
LightComponentfrom usingObject.definePropertyto usingget/setI confirm I have read the contributing guidelines and signed the Contributor License Agreement.