Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LightComponent properties port to get/set #6114

Merged
merged 28 commits into from
Mar 11, 2024
Merged

LightComponent properties port to get/set #6114

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
93f77ac
separated flags for types into tsconfig files
kpal81xd Mar 5, 2024
396a72c
WIP: changed lightcomponent to use get/set
kpal81xd Mar 6, 2024
a204ccb
WIP: added jsdoc comment to bake property
kpal81xd Mar 6, 2024
ffbd450
WIP: moved descriptions over to get/set in light component;
kpal81xd Mar 6, 2024
ce0450e
changed all properties to set/get jsdoc
kpal81xd Mar 6, 2024
442a873
set type to import Texture
kpal81xd Mar 6, 2024
e1a146a
Merge branch 'main' into types-fixes
kpal81xd Mar 6, 2024
c2e19a5
reverted tsconfig changes
kpal81xd Mar 7, 2024
e87a9d6
Merge branch 'main' into types-fixes
kpal81xd Mar 7, 2024
204ec8f
fixed type bug issue
kpal81xd Mar 7, 2024
de1a245
Merge branch 'main' into types-fixes
kpal81xd Mar 7, 2024
0bccd63
Merge branch 'main' into types-fixes
kpal81xd Mar 7, 2024
12b5c7b
added comment for upgrading light component to new version
kpal81xd Mar 7, 2024
f096945
Merge branch 'main' into types-fixes
kpal81xd Mar 7, 2024
bc2e3f9
lint fix
kpal81xd Mar 7, 2024
dc13143
Merge branch 'main' into types-fixes
kpal81xd Mar 7, 2024
5ed65e5
Merge branch 'main' into types-fixes
kpal81xd Mar 7, 2024
07ee69b
Merge branch 'main' into types-fixes
kpal81xd Mar 7, 2024
849acd2
Merge branch 'main' into types-fixes
kpal81xd Mar 8, 2024
60b99ee
Merge branch 'main' into types-fixes
kpal81xd Mar 8, 2024
9313769
Merge branch 'main' into types-fixes
kpal81xd Mar 8, 2024
1135511
Merge branch 'main' into types-fixes
kpal81xd Mar 11, 2024
e025817
Merge branch 'main' into types-fixes
kpal81xd Mar 11, 2024
206a563
Merge branch 'main' into types-fixes
kpal81xd Mar 11, 2024
f081abf
Update src/framework/components/light/component.js
kpal81xd Mar 11, 2024
8d29d74
Update src/framework/components/light/component.js
kpal81xd Mar 11, 2024
608a08a
Update src/framework/components/light/component.js
kpal81xd Mar 11, 2024
8ab9c6e
added ignore to light and justified comment blocks
kpal81xd Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@ typedocs
stats.html
.npmrc
examples/.npmrc
.prettierrc
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,8 @@
"build": "rollup -c",
"build:release": "rollup -c --environment target:release",
"build:debug": "rollup -c --environment target:debug",
"build:dts": "tsc src/index.js --outDir types --allowJs --declaration --emitDeclarationOnly",
"build:dts:extras": "tsc extras/index.js --allowJs --declaration --emitDeclarationOnly --outDir build/playcanvas-extras",
"build:dts": "tsc --project tsconfig.engine.json",
"build:dts:extras": "tsc --project tsconfig.extras.json",
kpal81xd marked this conversation as resolved.
Show resolved Hide resolved
"build:extras": "rollup -c --environment target:extras",
"build:es5": "rollup -c --environment target:es5",
"build:es6": "rollup -c --environment target:es6",
Expand Down
Loading
Loading