Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSDoc import dollar fixes #6215

Merged
merged 4 commits into from
Apr 2, 2024
Merged

JSDoc import dollar fixes #6215

merged 4 commits into from
Apr 2, 2024

Conversation

kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Apr 2, 2024

  • Use import when declaring types from files not referenced in current file (removes dollar on type rollup).
  • Set type of source in Channel to explicitly be globalThis.Node to stop conflict with animation Node class.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@kpal81xd kpal81xd requested a review from a team April 2, 2024 14:30
@kpal81xd kpal81xd self-assigned this Apr 2, 2024
@kpal81xd kpal81xd changed the title JSDoc import fixes JSDoc import dollar fixes Apr 2, 2024
@kpal81xd kpal81xd requested a review from mvaligursky April 2, 2024 14:33
@kpal81xd kpal81xd merged commit 44e4ad3 into main Apr 2, 2024
7 checks passed
@kpal81xd kpal81xd deleted the dollar-fixes branch April 2, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaligursky mvaligursky mvaligursky approved these changes

Assignees

@kpal81xd kpal81xd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpal81xd @mvaligursky