Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSDoc import dollar fixes #6215

Merged
merged 4 commits into from
Apr 2, 2024
Merged

JSDoc import dollar fixes #6215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4cf5860
fixed dollars for mouse input and touch event
kpal81xd Apr 2, 2024
ef72617
Merge branch 'main' into dollar-fixes
kpal81xd Apr 2, 2024
d925198
reverted touch changes
kpal81xd Apr 2, 2024
61dd5e4
removed dollar for Node
kpal81xd Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions src/framework/input/element-input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,18 +116,20 @@ class ElementInputEvent {
/**
* Create a new ElementInputEvent instance.
*
* @param {MouseEvent|TouchEvent} event - The MouseEvent or TouchEvent that was originally
* raised.
* @param {import('../../platform/input/mouse-event.js').MouseEvent
* |import('../../platform/input/touch-event.js').TouchEvent} event - MouseEvent or TouchEvent
* that was originally raised.
* @param {import('../components/element/component.js').ElementComponent} element - The
* ElementComponent that this event was originally raised on.
* @param {import('../components/camera/component.js').CameraComponent} camera - The
* CameraComponent that this event was originally raised via.
*/
constructor(event, element, camera) {
/**
* The MouseEvent or TouchEvent that was originally raised.
* MouseEvent or TouchEvent that was originally raised.
*
* @type {MouseEvent|TouchEvent}
* @type {import('../../platform/input/mouse-event.js').MouseEvent
* |import('../../platform/input/touch-event.js').TouchEvent}
*/
this.event = event;

Expand Down Expand Up @@ -170,7 +172,8 @@ class ElementMouseEvent extends ElementInputEvent {
/**
* Create an instance of an ElementMouseEvent.
*
* @param {MouseEvent} event - The MouseEvent that was originally raised.
* @param {import('../../platform/input/mouse-event.js').MouseEvent} event - The MouseEvent that
* was originally raised.
* @param {import('../components/element/component.js').ElementComponent} element - The
* ElementComponent that this event was originally raised on.
* @param {import('../components/camera/component.js').CameraComponent} camera - The
Expand Down Expand Up @@ -264,14 +267,14 @@ class ElementTouchEvent extends ElementInputEvent {
/**
* Create an instance of an ElementTouchEvent.
*
* @param {TouchEvent} event - The TouchEvent that was originally raised.
* @param {import('../../platform/input/touch-event.js').TouchEvent} event - The TouchEvent that was originally raised.
* @param {import('../components/element/component.js').ElementComponent} element - The
* ElementComponent that this event was originally raised on.
* @param {import('../components/camera/component.js').CameraComponent} camera - The
* CameraComponent that this event was originally raised via.
* @param {number} x - The x coordinate of the touch that triggered the event.
* @param {number} y - The y coordinate of the touch that triggered the event.
* @param {Touch} touch - The touch object that triggered the event.
* @param {import('../../platform/input/touch-event.js').Touch} touch - The touch object that triggered the event.
*/
constructor(event, element, camera, x, y, touch) {
super(event, element, camera);
Expand All @@ -280,22 +283,22 @@ class ElementTouchEvent extends ElementInputEvent {
* The Touch objects representing all current points of contact with the surface,
* regardless of target or changed status.
*
* @type {Touch[]}
* @type {import('../../platform/input/touch-event.js').Touch[]}
*/
this.touches = event.touches;
/**
* The Touch objects representing individual points of contact whose states changed between
* the previous touch event and this one.
*
* @type {Touch[]}
* @type {import('../../platform/input/touch-event.js').Touch[]}
*/
this.changedTouches = event.changedTouches;
this.x = x;
this.y = y;
/**
* The touch object that triggered the event.
*
* @type {Touch}
* @type {import('../../platform/input/touch-event.js').Touch}
*/
this.touch = touch;
}
Expand Down
1 change: 1 addition & 0 deletions src/platform/audio/channel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ class Channel {

this.manager = manager;

/** @type {globalThis.Node | null} */
this.source = null;

if (hasAudioContext()) {
Expand Down