Small JSDoc normalization/fixes #6369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mvaligursky
approved these changes
May 15, 2024
slimbuck
pushed a commit
to slimbuck/engine
that referenced
this pull request
May 20, 2024
* Fix/normalize examples/utils/plugins/rollup-copy-static.mjs, targets#once is optional * Mark `y`/`z` as optional when `x` can be the entire `Vec3`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem with TS style types is:
So I normalized that into JSDoc style and added some description what it is about.
targets.onceis also optional, which the TS type didn't point out, leading to type mismatch.I confirm I have read the contributing guidelines and signed the Contributor License Agreement.