Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small JSDoc normalization/fixes #6369

Merged
merged 2 commits into from
May 15, 2024
Merged

Small JSDoc normalization/fixes #6369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57734d5
Fix/normalize examples/utils/plugins/rollup-copy-static.mjs, targets#…
kungfooman May 15, 2024
ffbf441
Mark `y`/`z` as optional when `x` can be the entire `Vec3`
kungfooman May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion examples/utils/plugins/rollup-copy-static.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ const copied = new Set();
* This plugin copies static files from source to destination.
*
* @param {string} nodeEnv - The node environment.
* @param {{ src: string, dest: string, once: boolean }[]} targets - Array of source and destination objects.
* @param {object[]} targets - Array of source and destination objects.
* @param {string} targets.src - File or entire dir.
* @param {string} targets.dest - File or entire dir, usually into `dist/`.
* @param {boolean} [targets.once] - Copy files only once for speed-up (external libs).
* @param {boolean} log - Log the copy status.
* @returns {import('rollup').Plugin} The plugin.
*/
Expand Down
8 changes: 4 additions & 4 deletions src/framework/components/element/component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1735,8 +1735,8 @@ class ElementComponent extends Component {
* Patched method for setting the position.
*
* @param {number|Vec3} x - The x coordinate or Vec3
* @param {number} y - The y coordinate
* @param {number} z - The z coordinate
* @param {number} [y] - The y coordinate
* @param {number} [z] - The z coordinate
* @private
*/
_setPosition(x, y, z) {
Expand Down Expand Up @@ -1764,8 +1764,8 @@ class ElementComponent extends Component {
* Patched method for setting the local position.
*
* @param {number|Vec3} x - The x coordinate or Vec3
* @param {number} y - The y coordinate
* @param {number} z - The z coordinate
* @param {number} [y] - The y coordinate
* @param {number} [z] - The z coordinate
* @private
*/
_setLocalPosition(x, y, z) {
Expand Down