Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Up To Latest #193

Merged
merged 9 commits into from
Oct 25, 2023

Merge branch 'main' into sync/167e780a5a4576e4e0474dcce1548a053fa0fa87

dbf2921
Select commit
Loading
Failed to load commit list.
Merged

Sync Up To Latest #193

Merge branch 'main' into sync/167e780a5a4576e4e0474dcce1548a053fa0fa87
dbf2921
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 25, 2023 in 0s

82.23% (-0.04%) compared to 766bb5a

View this Pull Request on Codecov

82.23% (-0.04%) compared to 766bb5a

Details

Codecov Report

Attention: 110 lines in your changes are missing coverage. Please review.

Comparison is base (766bb5a) 82.26% compared to head (dbf2921) 82.23%.
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   82.26%   82.23%   -0.04%     
==========================================
  Files         118      129      +11     
  Lines        4117     4519     +402     
  Branches     1031     1114      +83     
==========================================
+ Hits         3387     3716     +329     
- Misses        471      526      +55     
- Partials      259      277      +18     
Files Coverage Δ
core/player/src/binding-grammar/custom/index.ts 94.77% <100.00%> (ø)
core/player/src/binding/binding.ts 100.00% <ø> (ø)
core/player/src/binding/index.ts 93.44% <100.00%> (+0.22%) ⬆️
core/player/src/binding/resolver.ts 80.95% <ø> (ø)
core/player/src/controllers/flow/controller.ts 100.00% <100.00%> (ø)
core/player/src/controllers/flow/flow.ts 100.00% <100.00%> (ø)
core/player/src/controllers/view/controller.ts 95.65% <100.00%> (+0.91%) ⬆️
core/player/src/data/noop-model.ts 33.33% <ø> (ø)
core/player/src/expressions/evaluator.ts 81.04% <100.00%> (+0.91%) ⬆️
core/player/src/expressions/types.ts 100.00% <100.00%> (ø)
... and 47 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.