Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncNodePlugin- use named export, port iOS plugin #295

Merged
merged 8 commits into from
Feb 7, 2024
Merged

AsyncNodePlugin- use named export, port iOS plugin #295

merged 8 commits into from
Feb 7, 2024

Conversation

nancywu1
Copy link
Contributor

@nancywu1 nancywu1 commented Feb 7, 2024

  • Use named export instead of default to be consistent with other plugins
  • Porting iOSPlugin

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

@nancywu1 nancywu1 requested a review from KetanReddy as a code owner February 7, 2024 18:06
@nancywu1 nancywu1 merged commit e1c6102 into main Feb 7, 2024
9 checks passed
@nancywu1 nancywu1 deleted the iOS-Async-Node-Plugin branch February 7, 2024 21:00
This was referenced Feb 10, 2024
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborawski hborawski hborawski approved these changes

@adierkens adierkens Awaiting requested review from adierkens adierkens is a code owner

@KetanReddy KetanReddy Awaiting requested review from KetanReddy KetanReddy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nancywu1 @hborawski