Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This PR enables to add footer component to info reference asset in android #411

Merged

Conversation

sakuntala-motukuri
Copy link
Contributor

@sakuntala-motukuri sakuntala-motukuri commented Jul 3, 2024

Bazel 6 android base add footer to info reference asset

Change Type (required)

Indicate the type of change your pull request is:

Please find test results:

All Tests passed in local :
https://app.buildbuddy.io/invocation/aae39ed3-dde9-40ee-9518-af24a07eb123

image

  • patch
  • minor
  • major

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

@sakuntala-motukuri sakuntala-motukuri force-pushed the bazel-6-android-base-Add-footer-to-info-reference-asset branch from 0dbb2a3 to 156ce68 Compare July 5, 2024 17:38
@sugarmanz
Copy link
Member

/canary

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.75%. Comparing base (55d59d6) to head (ddc250f).

Additional details and impacted files
@@           Coverage Diff            @@
##           bazel-6     #411   +/-   ##
========================================
  Coverage    91.75%   91.75%           
========================================
  Files          339      339           
  Lines        27044    27044           
  Branches      1962     1962           
========================================
  Hits         24814    24814           
  Misses        2216     2216           
  Partials        14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from bazel-6-android to bazel-6 July 9, 2024 21:12
Copy link
Member

@sugarmanz sugarmanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - we'll just want to see the tests pass (should be working once you rebase on bazel-6).

I also think you'll need to update the info-modal-flow mock (that's what's used in your test case) to have a footer for your test update to pass.

@sakuntala-motukuri sakuntala-motukuri force-pushed the bazel-6-android-base-Add-footer-to-info-reference-asset branch from a326778 to 4037244 Compare July 11, 2024 20:09
brocollie08
brocollie08 previously approved these changes Jul 12, 2024
@sakuntala-motukuri sakuntala-motukuri marked this pull request as ready for review July 13, 2024 05:21
@sakuntala-motukuri sakuntala-motukuri force-pushed the bazel-6-android-base-Add-footer-to-info-reference-asset branch from ddc250f to e8f305c Compare July 15, 2024 16:54
@sakuntala-motukuri sakuntala-motukuri changed the base branch from bazel-6 to main July 15, 2024 16:55
@sakuntala-motukuri sakuntala-motukuri dismissed brocollie08’s stale review July 15, 2024 16:55

The base branch was changed.

@sugarmanz sugarmanz enabled auto-merge (squash) July 15, 2024 16:55
@sakuntala-motukuri sakuntala-motukuri changed the title bazel-6-android-base-Add-footer-to-info-reference-asset This PR enables to add footer component to info reference asset in android Jul 15, 2024
@sugarmanz sugarmanz merged commit ab58074 into main Jul 15, 2024
9 checks passed
@sugarmanz sugarmanz deleted the bazel-6-android-base-Add-footer-to-info-reference-asset branch July 15, 2024 17:27
This was referenced Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants