-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This PR enables to add footer component to info reference asset in android #411
This PR enables to add footer component to info reference asset in android #411
Conversation
0dbb2a3
to
156ce68
Compare
/canary |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## bazel-6 #411 +/- ##
========================================
Coverage 91.75% 91.75%
========================================
Files 339 339
Lines 27044 27044
Branches 1962 1962
========================================
Hits 24814 24814
Misses 2216 2216
Partials 14 14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good - we'll just want to see the tests pass (should be working once you rebase on bazel-6
).
I also think you'll need to update the info-modal-flow
mock (that's what's used in your test case) to have a footer for your test update to pass.
a326778
to
4037244
Compare
ddc250f
to
e8f305c
Compare
The base branch was changed.
Bazel 6 android base add footer to info reference asset
Change Type (required)
Indicate the type of change your pull request is:
Please find test results:
All Tests passed in local :
https://app.buildbuddy.io/invocation/aae39ed3-dde9-40ee-9518-af24a07eb123
patch
minor
major
Does your PR have any documentation updates?